Skip to contentSkip to conversation

security/smack/smack_lsm.c: cleanup kernel-doc

PATCH In review Qinghuang Feng 2 participants 2 messages Feb 9, 2009 – Feb 15, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 security/smack/smack_lsm.c: cleanup kernel-doc

Remove comments which refer to nonexistent arguments.

---

security/smack/smack_lsm.c +1 -3
index 0278bc0..02c48ea 100644
@@ -538,7 +538,6 @@ static int smack_inode_rename(struct inode *old_inode,
  * smack_inode_permission - Smack version of permission()
  * @inode: the inode in question
  * @mask: the access requested
- * @nd: unused
  *
  * This is the important Smack hook.
  *
@@ -701,8 +700,7 @@ static int smack_inode_removexattr(struct dentry *dentry, const char *name)
  * @inode: the object
  * @name: attribute name
  * @buffer: where to put the result
- * @size: size of the buffer
- * @err: unused
+ * @alloc: unused
  *
  * Returns the size of the attribute or an error code
  */
#1 lore raw
Quoted 18 lines · On Mon, 9 Feb 2009 18:58:25 +0800 Qinghuang Feng wrote:

Remove comments which refer to nonexistent arguments.

---

security/smack/smack_lsm.c +0 -1
index 0278bc0..02c48ea 100644
@@ -538,7 +538,6 @@ static int smack_inode_rename(struct inode *old_inode,
  * smack_inode_permission - Smack version of permission()
  * @inode: the inode in question
  * @mask: the access requested
- * @nd: unused
  *
  * This is the important Smack hook.
  *
@@ -701,8 +700,7 @@ static int smack_inode_removexattr(struct dentry *dentry, const char *name)
  * @inode: the object

security/smack/smack_lsm.c static int smack_inode_removexattr(struct dentry *dentry, const char *name)

Quoted 10 lines
security/smack/smack_lsm.c +1 -3
  * @name: attribute name
  * @buffer: where to put the result
- * @size: size of the buffer
- * @err: unused
+ * @alloc: unused
  *
  * Returns the size of the attribute or an error code
  */
 
--

ACK, but there are lots of other kernel-doc problems in security/smack/ that could stand to be fixed...

Thanks,
---
~Randy