Skip to contentSkip to conversation

i8327: fix outb() parameter order

PATCH In review Clemens Ladisch 2 participants 2 messages Feb 10, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i8327: fix outb() parameter order

In i8237A_resume(), when resetting the DMA controller, the parameters to dma_outb() were mixed up.

arch/x86/kernel/i8237.c +2 -2
@@ -28,8 +28,8 @@ static int i8237A_resume(struct sys_devi
 
 	flags = claim_dma_lock();
 
-	dma_outb(DMA1_RESET_REG, 0);
-	dma_outb(DMA2_RESET_REG, 0);
+	dma_outb(0, DMA1_RESET_REG);
+	dma_outb(0, DMA2_RESET_REG);
 
 	for (i = 0;i < 8;i++) {
 		set_dma_addr(i, 0x000000);
#1 lore raw
Quoted 8 lines · Clemens Ladisch

In i8237A_resume(), when resetting the DMA controller, the parameters to dma_outb() were mixed up.

arch/x86/kernel/i8237.c static int i8237A_resume(struct sys_devi · line 35

Quoted 10 lines
arch/x86/kernel/i8237.c +2 -2
@@ -28,8 +28,8 @@ static int i8237A_resume(struct sys_devi
 
 	flags = claim_dma_lock();
 
-	dma_outb(DMA1_RESET_REG, 0);
-	dma_outb(DMA2_RESET_REG, 0);
+	dma_outb(0, DMA1_RESET_REG);
+	dma_outb(0, DMA2_RESET_REG);
 
 	for (i = 0;i < 8;i++) {
 		set_dma_addr(i, 0x000000);

Good catch, applied to tip:x86/urgent, thanks!

Ingo