Skip to contentSkip to conversation

ACPI: get_throttling_state() cannot be larger state_count

PATCH In review Roel Kluin 2 participants 2 messages Feb 11, 2009 – Feb 12, 2009 ACPI

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 ACPI: get_throttling_state() cannot be larger state_count

With for(i = 0; i < n; i++) { ... } i reaches n.

---

drivers/acpi/processor_throttling.c +1 -1
index d278381..6feb9ab 100644
@@ -785,7 +785,7 @@ static int acpi_get_throttling_state(struct acpi_processor *pr,
 		if (tx->control == value)
 			break;
 	}
-	if (i > pr->throttling.state_count)
+	if (i >= pr->throttling.state_count)
 		i = -1;
 	return i;
 }
Acked-by on v1 1/1
#1 lore raw

On Thu, 2009-02-12 at 03:50 +0800, Roel Kluin wrote:
In fact the function of acpi_get_throttling_state will be used only
when the _PTC(throttling object) exists. The status argument will be compared with the _TSS package. In theory it will be found in the _TSS package and the corresponding T-state will be obtained.

But from the program logic it will be OK.

Thanks.

Quoted 21 lines

With for(i = 0; i < n; i++) { ... } i reaches n.

---

drivers/acpi/processor_throttling.c +1 -2
index d278381..6feb9ab 100644
@@ -785,7 +785,7 @@ static int acpi_get_throttling_state(struct acpi_processor *pr,
 		if (tx->control == value)
 			break;
 	}
-	if (i > pr->throttling.state_count)
+	if (i >= pr->throttling.state_count)
 		i = -1;
 	return i;
 }
--

To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html