Skip to contentSkip to conversation

bootm: Reduce the unnecessary memmove

PATCH New Minkyu Kang 3 participants 5 messages Feb 18, 2009 – Feb 24, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bootm: Reduce the unnecessary memmove

Although load address and image start address are same address, bootm command always does memmove.
That is unnecessary memmove and can be taken few milliseconds (about 500 msec to 1000 msec).
If skip this memmove, we can reduce the boot time.

---
 common/cmd_bootm.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
common/cmd_bootm.c +4 -2
index 07f6c6b..6fdeef4 100644
@@ -340,8 +340,10 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
 		} else {
 			printf ("   Loading %s ... ", type_name);
 
-			memmove_wd ((void *)load,
-				   (void *)image_start, image_len, CHUNKSZ);
+			if (load != image_start) {
+				memmove_wd ((void *)load,
+						(void *)image_start, image_len, CHUNKSZ);
+			}
 		}
 		*load_end = load + image_len;
 		puts("OK\n");
#1 lore raw

PATCH 1/1 bootm: Reduce the unnecessary memmove

Dear Minkyu Kang,

Quoted 10 lines · In message <[email protected]> you wrote:

Although load address and image start address are same address, bootm command always does memmove.
That is unnecessary memmove and can be taken few milliseconds (about 500 msec to 1000 msec).
If skip this memmove, we can reduce the boot time.

---
 common/cmd_bootm.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If some day we are defeated, well, war has  its  fortunes,  good  and
bad.
	-- Commander Kor, "Errand of Mercy", stardate 3201.7
#2 lore raw

PATCH 1/1 bootm: Reduce the unnecessary memmove

In reply to Minkyu Kang
Quoted 28 lines · Minkyu Kang

Although load address and image start address are same address, bootm command always does memmove.
That is unnecessary memmove and can be taken few milliseconds (about 500 msec to 1000 msec).
If skip this memmove, we can reduce the boot time.

---
 common/cmd_bootm.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
common/cmd_bootm.c +4 -2
index 07f6c6b..6fdeef4 100644
@@ -340,8 +340,10 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
 		} else {
 			printf ("   Loading %s ... ", type_name);
 
-			memmove_wd ((void *)load,
-				   (void *)image_start, image_len, CHUNKSZ);
+			if (load != image_start) {
+				memmove_wd ((void *)load,
+						(void *)image_start, image_len, CHUNKSZ);
+			}
 		}
 		*load_end = load + image_len;
 		puts("OK\n");
Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Sorry for the late reply, but would it be better to put the test of source == destination into the memmove_wd() function?

Best regards,
Larry

#3 lore raw

PATCH 1/1 bootm: Reduce the unnecessary memmove

Dear Larry Johnson,

Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 6 lines

Although load address and image start address are same address, bootm command always does memmove.
That is unnecessary memmove and can be taken few milliseconds (about 500 msec to 1000 msec).
If skip this memmove, we can reduce the boot time.

...

Quoted 2 lines

Sorry for the late reply, but would it be better to put the test of source == destination into the memmove_wd() function?

Yes, indeed.

Can you please send a patch?

Best regards,

Wolfgang Denk

Signature · 9 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
This was an  amazing  creation  using  small  squares  of  compressed
vegetable  matter on which letters were made by means of small carbon
particles from a stylus, giving an effect similar to the  traditional
word-processor  screen. It seemed amazingly portable and I never once
saw him have to change the batteries.
        - Terry Pratchett & Stephen Briggs, _The Discworld Companion_
#4 lore raw

PATCH 1/1 Move test for unnecessary memmove to memmove_wd()

---
 common/cmd_bootm.c |    7 ++-----
 common/image.c     |    3 +++
 2 files changed, 5 insertions(+), 5 deletions(-)
common/cmd_bootm.c +2 -5
index 6fdeef4..bc38aaa 100644
@@ -339,11 +339,8 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
 			printf ("   XIP %s ... ", type_name);
 		} else {
 			printf ("   Loading %s ... ", type_name);
-
-			if (load != image_start) {
-				memmove_wd ((void *)load,
-						(void *)image_start, image_len, CHUNKSZ);
-			}
+			memmove_wd ((void *)load, (void *)image_start,
+					image_len, CHUNKSZ);
 		}
 		*load_end = load + image_len;
 		puts("OK\n");
common/image.c +3 -0
index daa68bc..1dc9e4e 100644
@@ -457,6 +457,9 @@ phys_size_t getenv_bootm_size(void)
 
 void memmove_wd (void *to, void *from, size_t len, ulong chunksz)
 {
+	if (to == from)
+		return;
+
 #if defined(CONFIG_HW_WATCHDOG) || defined(CONFIG_WATCHDOG)
 	while (len > 0) {
 		size_t tail = (len > chunksz) ? chunksz : len;
Signature · 1 line
1.5.4.3