Skip to contentSkip to conversation

cgroups: update documentation about css_set hash table

PATCH In review Li Zefan 3 participants 3 messages Feb 18, 2009 1 message not in the archive Documentation

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 cgroups: update documentation about css_set hash table

The css_set hash table was introduced in 2.6.26, so update the documentation accordingly.

---
 Documentation/cgroups/cgroups.txt |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
Documentation/cgroups/cgroups.txt +2 -4
index d9e5d6f..93feb84 100644
@@ -252,10 +252,8 @@ cgroup file system directories.
 When a task is moved from one cgroup to another, it gets a new
 css_set pointer - if there's an already existing css_set with the
 desired collection of cgroups then that group is reused, else a new
-css_set is allocated. Note that the current implementation uses a
-linear search to locate an appropriate existing css_set, so isn't
-very efficient. A future version will use a hash table for better
-performance.
+css_set is allocated. The appropriate existing css_set is located by
+looking into a hash table.
 
 To allow access from a cgroup to the css_sets (and hence tasks)
 that comprise it, a set of cg_cgroup_link objects form a lattice;
Signature · 1 line
1.5.4.rc3

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw
Quoted 4 lines · Li Zefan

The css_set hash table was introduced in 2.6.26, so update the documentation accordingly.

Quoted 24 lines
---
 Documentation/cgroups/cgroups.txt |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
Documentation/cgroups/cgroups.txt +2 -5
index d9e5d6f..93feb84 100644
@@ -252,10 +252,8 @@ cgroup file system directories.
 When a task is moved from one cgroup to another, it gets a new
 css_set pointer - if there's an already existing css_set with the
 desired collection of cgroups then that group is reused, else a new
-css_set is allocated. Note that the current implementation uses a
-linear search to locate an appropriate existing css_set, so isn't
-very efficient. A future version will use a hash table for better
-performance.
+css_set is allocated. The appropriate existing css_set is located by
+looking into a hash table.
 
 To allow access from a cgroup to the css_sets (and hence tasks)
 that comprise it, a set of cg_cgroup_link objects form a lattice;
--

1.5.4.rc3

Acked-by on v1 1/1
#3 lore raw
In reply to Li Zefan
Quoted 4 lines · Li Zefan

The css_set hash table was introduced in 2.6.26, so update the documentation accordingly.

Quoted 24 lines
---
 Documentation/cgroups/cgroups.txt |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
Documentation/cgroups/cgroups.txt +2 -5
index d9e5d6f..93feb84 100644
@@ -252,10 +252,8 @@ cgroup file system directories.
 When a task is moved from one cgroup to another, it gets a new
 css_set pointer - if there's an already existing css_set with the
 desired collection of cgroups then that group is reused, else a new
-css_set is allocated. Note that the current implementation uses a
-linear search to locate an appropriate existing css_set, so isn't
-very efficient. A future version will use a hash table for better
-performance.
+css_set is allocated. The appropriate existing css_set is located by
+looking into a hash table.
 
 To allow access from a cgroup to the css_sets (and hence tasks)
 that comprise it, a set of cg_cgroup_link objects form a lattice;
--

1.5.4.rc3