Skip to contentSkip to conversation

sundance: missing parentheses?

PATCH Applied Roel Kluin 2 participants 2 messages Feb 18, 2009 – Feb 20, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 sundance: missing parentheses?

Please review. --------------------------->8-------------8<------------------------------ Add missing parentheses

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/sundance.c +1 -1
index feaf0e0..43695b7 100644
@@ -909,7 +909,7 @@ static void check_duplex(struct net_device *dev)
 			printk(KERN_INFO "%s: Setting %s-duplex based on MII #%d "
 				   "negotiated capability %4.4x.\n", dev->name,
 				   duplex ? "full" : "half", np->phys[0], negotiated);
-		iowrite16(ioread16(ioaddr + MACCtrl0) | duplex ? 0x20 : 0, ioaddr + MACCtrl0);
+		iowrite16(ioread16(ioaddr + MACCtrl0) | (duplex ? 0x20 : 0), ioaddr + MACCtrl0);
 	}
 }