Skip to contentSkip to conversation

Fix transmit LED on Acer Aspire One

PATCH Xose Vazquez Perez 1 participant 1 message Feb 23, 2009

lore
Share & tools
lore
#0 lore raw
Quoted 16 lines · Bob Copeland
Quoted 10 lines · John W. Linville

Review

Quoted 8 lines · Peter Chubb
(quoted diff) +6 -0
+     /* Enable softled on Acer Aspire One */
+     else if (pdev->subsystem_vendor == 0x105b && pdev->subsystem_device == 0xe008) {
+             __set_bit(ATH_STAT_LEDSOFT, sc->status);
+             sc->led_pin = 3;
+             sc->led_on = 0;
+     }
      if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
              goto out;
Quoted 3 lines

Any comment on this from the ath5k guys? That 0x105b subvendor ID would seem to correspond to "Foxconn International, Inc.", which doesn't sound much like "Acer"...

Quoted 7 lines

It's already in wireless-testing with similar values.

Not quite apropos to this patch, someone with the ambit chipset said the values didn't match up with his laptop, so we do need to add a subsystem_device test I think, but it should have a #define in pci.h. In any case there's usually no harm in enabling the wrong gpio pin, unless rfkill happens to sit there.

from windows drivers:

%ATHER.DeviceDesc.3067% = ATHER_DEV_04281468.ndi, PCI\VEN_168C&DEV_001C&SUBSYS_E008105B

ATHER.DeviceDesc.3067 = "Atheros AR5007EG Wireless Network Adapter"

regards,

Signature · 1 line
Polycommander, Erkowit, Urquiola, Andros Patria, Cason, Aegean Sea, Prestige, ...