Skip to contentSkip to conversation

make should fail if it cannot build hvmloader

PATCH In review Alex Zeffertt 2 participants 2 messages Feb 24, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make should fail if it cannot build hvmloader

At the moment, if the tools required to build hvmloader are not present, make will continue building the rest of the system and not indicate that an error has occurred.

This patch causes make to stop and print a message saying that some packages are missing on the build machine and need to be installed.

Please consider applying the patch.

Regards,

Alex Zeffertt

# HG changeset patch
# User Alex Zeffertt <[email protected]>
# Date 1235477069 0
# Node ID 72a8404eea4035d38129e2b2097fac5613f05f07
# Parent 32b15413749255e0cd518f25d9202759586dcb27
Make build fail if packages required to build hvmloader not present ... rather than just continuing as if nothing's gone wrong.

Also, corrected the message generated by the makefile which says what packages are required.

tools/firmware/Makefile +5 -6
diff -r 32b154137492 -r 72a8404eea40 tools/firmware/Makefile
@@ -15,13 +15,12 @@
 .PHONY: all
 all:
 	@set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut -d' ' -f 3 | awk -F. '{ printf "0x%02x%02x%02x", $$1, $$2, $$3}'`)) -lt $$((0x00100e)) ] ; then \
-	echo "==========================================================="; \
-	echo "Require dev86 package version >= 0.16.14 to build firmware!"; \
-	echo "(visit http://www.cix.co.uk/~mayday for more information)"; \
-	echo "==========================================================="; \
-	else \
+	echo "=================================================================="; \
+	echo "Require bin86 & bcc packages version >= 0.16.14 to build firmware!"; \
+	echo "=================================================================="; \
+	false ; \
+	fi
 	$(MAKE) subdirs-$@; \
-	fi
 
 
 .PHONY: install

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Acked-by on v1 1/1
#1 lore raw

Alex Zeffertt writes ("[Xen-devel] [PATCH] [build system] make should fail if it cannot build hvmloader"):

Quoted 3 lines

At the moment, if the tools required to build hvmloader are not present, make will continue building the rest of the system and not indicate that an error has occurred.

...

Quoted 1 line

Ian.