ppp: remove some pointless conditionals before kfree_skb()
Subsystems (3)
PATCH 1/1 ppp: remove some pointless conditionals before kfree_skb()
Remove some pointless conditionals before kfree_skb().
Signed-off-by Wei Yongjun <[email protected]>
--- drivers/net/ppp_async.c | 6 ++---- drivers/net/ppp_generic.c | 6 ++---- drivers/net/ppp_synctty.c | 3 +-- 3 files changed, 5 insertions(+), 10 deletions(-)
drivers/net/ppp_async.c +2 -4
@@ -233,11 +233,9 @@ ppp_asynctty_close(struct tty_struct *tty)tasklet_kill (&ap->tsk);ppp_unregister_channel (&ap->chan); -if (ap->rpkt) -kfree_skb (ap->rpkt); +kfree_skb (ap->rpkt);skb_queue_purge (&ap->rqueue); -if (ap->tpkt) -kfree_skb (ap->tpkt); +kfree_skb (ap->tpkt);kfree (ap); }
drivers/net/ppp_generic.c +2 -4
@@ -1245,8 +1245,7 @@ ppp_send_frame(struct ppp *ppp, struct sk_buff *skb)return ; drop: -if (skb) -kfree_skb (skb); +kfree_skb (skb); ++ppp->dev->stats.tx_errors; }
@@ -2658,8 +2657,7 @@ static void ppp_destroy_interface(struct ppp *ppp) ppp->active_filter =NULL ;#endif /* CONFIG_PPP_FILTER */ -if (ppp->xmit_pending) -kfree_skb (ppp->xmit_pending); +kfree_skb (ppp->xmit_pending);free_netdev (ppp->dev); }
drivers/net/ppp_synctty.c +1 -2
@@ -281,8 +281,7 @@ ppp_sync_close(struct tty_struct *tty)ppp_unregister_channel (&ap->chan);skb_queue_purge (&ap->rqueue); -if (ap->tpkt) -kfree_skb (ap->tpkt); +kfree_skb (ap->tpkt);kfree (ap); }
Signature · 1 line
1.5.3.8
From: Wei Yongjun <[email protected]>
Date: Wed, 25 Feb 2009 18:16:08 +0800
Quoted 3 lines
Remove some pointless conditionals before
kfree_skb().Signed-off-by Wei Yongjun <[email protected]>
Applied.