Skip to contentSkip to conversation

cxgb3i: remove some pointless conditionals before kfree_skb()

PATCH New Wei Yongjun 1 participant 1 message Feb 25, 2009 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cxgb3i: remove some pointless conditionals before kfree_skb()

Remove some pointless conditionals before kfree_skb().

---
 drivers/scsi/cxgb3i/cxgb3i_offload.c |    9 +++------
 drivers/scsi/cxgb3i/cxgb3i_pdu.c     |    3 +--
 2 files changed, 4 insertions(+), 8 deletions(-)
drivers/scsi/cxgb3i/cxgb3i_offload.c +3 -6
index a865f1f..8b3754a 100644
@@ -1208,12 +1208,9 @@ static int do_wr_ack(struct t3cdev *cdev, struct sk_buff *skb, void *ctx)
  */
 static void c3cn_free_cpl_skbs(struct s3_conn *c3cn)
 {
-	if (c3cn->cpl_close)
-		kfree_skb(c3cn->cpl_close);
-	if (c3cn->cpl_abort_req)
-		kfree_skb(c3cn->cpl_abort_req);
-	if (c3cn->cpl_abort_rpl)
-		kfree_skb(c3cn->cpl_abort_rpl);
+	kfree_skb(c3cn->cpl_close);
+	kfree_skb(c3cn->cpl_abort_req);
+	kfree_skb(c3cn->cpl_abort_rpl);
 }
 
 static int c3cn_alloc_cpl_skbs(struct s3_conn *c3cn)
drivers/scsi/cxgb3i/cxgb3i_pdu.c +1 -2
index ce7ce8c..a0d4f43 100644
@@ -149,8 +149,7 @@ void cxgb3i_conn_cleanup_task(struct iscsi_task *task)
 	struct iscsi_tcp_task *tcp_task = task->dd_data;
 
 	/* never reached the xmit task callout */
-	if (tcp_task->dd_data)
-		kfree_skb(tcp_task->dd_data);
+	kfree_skb(tcp_task->dd_data);
 	tcp_task->dd_data = NULL;
 
 	/* MNC - Do we need a check in case this is called but
Signature · 1 line
1.5.3.8