watchdog: fsl_get_sys_freq() failure not noticed
PATCH 1/1 watchdog: fsl_get_sys_freq() failure not noticed
Maybe it is nicer to do a test like:
if (freq < MAX_FREQ)
but I don't know what MAX_FREQ should be. ------------------------------>8-------------8<--------------------------------- fsl_get_sys_freq() may return -1 when 'soc' isn't found, but in gef_wdt_probe() 'freq' is unsigned, so the test doesn't catch that.
---
drivers/watchdog/gef_wdt.c +1 -1
@@ -269,7 +269,7 @@ static int __devinit gef_wdt_probe(struct of_device *dev, bus_clk =133 ;/* in MHz */ freq =fsl_get_sys_freq (); -if (freq >0 ) +if (freq !=-1 ) bus_clk = freq;/* Map devices registers into memory */
Hi Roel,
Quoted 16 lines
Maybe it is nicer to do a test like:
if (freq <
MAX_FREQ)but I don't know what
MAX_FREQshould be. ------------------------------>8-------------8<---------------------------------fsl_get_sys_freq()may return -1 when 'soc' isn't found, but ingef_wdt_probe()'freq' is unsigned, so the test doesn't catch that.Signed-off-by Roel Kluin <[email protected]>---
drivers/watchdog/gef_wdt.c +0
-0
drivers/watchdog/gef_wdt.c static int __devinit gef_wdt_probe(struct of_device *dev, · line 275
Quoted 8 lines
drivers/watchdog/gef_wdt.c +1
-1@@ -269,7 +269,7 @@ static int __devinit gef_wdt_probe(struct of_device *dev, bus_clk =133 ;/* in MHz */ freq =fsl_get_sys_freq (); -if (freq >0 ) +if (freq !=-1 ) bus_clk = freq;/* Map devices registers into memory */
patch added into the linux-2.6-watchdog-next tree.
Will sent it to linus for inclusion into main kernel tree tonight together with some other fixes.
Kind regards,
Wim.