Skip to contentSkip to conversation

Enable NV96 support

PATCH In review Victor Stinner 2 participants 3 messages Mar 6, 2009 – Mar 7, 2009 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Enable NV96 support

Add NV96 in NV9X_GRCLASS8297_CHIPSETS bitmask and remove the test blocking NV9x (another test is already present above).

From d6dbc4e172be2d6aa6155b5621f5e9acfa13b12d Mon Sep 17 00:00:00 2001
From: Victor Stinner <victor.stinner-XgyrR7WU8tJ8UrSeD/[email protected]>
Date: Fri, 6 Mar 2009 14:08:00 +0100
Subject: [PATCH] Enable NV96 support

Add NV96 in NV9X_GRCLASS8297_CHIPSETS bitmask and remove the test blocking NV9x (another test is already present above)

---
 src/gallium/drivers/nv50/nv50_screen.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
src/gallium/drivers/nv50/nv50_screen.c +1 -7
index 9bf5e8c..4130ede 100644
@@ -31,7 +31,7 @@
 
 #define NV5X_GRCLASS5097_CHIPSETS 0x00000001
 #define NV8X_GRCLASS8297_CHIPSETS 0x00000050
-#define NV9X_GRCLASS8297_CHIPSETS 0x00000014
+#define NV9X_GRCLASS8297_CHIPSETS 0x00000054
 
 static boolean
 nv50_screen_is_format_supported(struct pipe_screen *pscreen,
@@ -190,12 +190,6 @@ nv50_screen_create(struct pipe_winsys *ws, struct nouveau_winsys *nvws)
 	}
 
 	/* 3D object */
-	if ((chipset & 0xf0) != 0x50 && (chipset & 0xf0) != 0x80) {
-		NOUVEAU_ERR("Not a G8x chipset\n");
-		nv50_screen_destroy(&screen->pipe);
-		return NULL;
-	}
-
 	switch (chipset & 0xf0) {
 	case 0x50:
 		if (NV5X_GRCLASS5097_CHIPSETS & (1 << (chipset & 0x0f)))
Signature · 1 line
1.5.6.3

_______________________________________________
Nouveau mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau

#2 lore raw
In reply to a message not in the archive

Le Friday 06 March 2009 14:09:48 Victor Stinner, vous avez écrit :

Quoted 2 lines

Add NV96 in NV9X_GRCLASS8297_CHIPSETS bitmask and remove the test blocking NV9x (another test is already present above).

Note: my patch only disables the test on the chipset version, but glxgears crashed my Xorg :-)

Signature · 6 lines
Victor Stinner aka haypo
http://www.haypocalc.com/blog/
_______________________________________________
Nouveau mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau
#3 lore raw
In reply to a message not in the archive
Quoted 2 lines · Victor Stinner

Add NV96 in NV9X_GRCLASS8297_CHIPSETS bitmask and remove the test blocking NV9x (another test is already present above).

I didn't commit this as we could simplify selection quite a bit on G80.

Thanks for the reminder it needed doing though!
Ben.

Quoted 4 lines

_______________________________________________
Nouveau mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau