powerpc: Remove extra semicolon in fsl_soc.c (2nd try)

PATCH In review Johns Daniel 2 participants 2 messages Mar 14, 2009 – Mar 15, 2009 PowerPC

Share & tools

Johns Daniel

author

2009-03-14 15:10 UTC #0 lore raw

PATCH 1/1 powerpc: Remove extra semicolon in fsl_soc.c (2nd try)

TSEC/MDIO will not work with older device trees because of a semicolon at the end of a macro resulting in an empty for loop body.

This fix only applies to 2.6.28; this code is gone in 2.6.29, according to Grant Likely!

Signed-off-by Johns Daniel <[email protected] <mailto:[email protected]>>

======================================

arch/powerpc/sysdev/fsl_soc.c renamed from arch/powerpc/sysdev/fsl_soc.c.orig +0 -0

@@ -257,7 +257,7 @@ static int __init gfar_mdio_of_init(void

		gfar_mdio_of_init_one(np);

	/* try the deprecated version */
-	for_each_compatible_node(np, "mdio", "gianfar");
+	for_each_compatible_node(np, "mdio", "gianfar")
		gfar_mdio_of_init_one(np);

	return 0;

Grant Likely

Acked-by on v1 1/1

2009-03-15 02:01 UTC #1 lore raw

Quoted 4 lines · Johns Daniel

TSEC/MDIO will not work with older device trees because of a semicolon at the end of a macro resulting in an empty for loop body.
This fix only applies to 2.6.28; this code is gone in 2.6.29, according t=

Quoted 4 lines

Grant Likely!
Signed-off-by Johns Daniel <[email protected]
<mailto:[email protected]>>

Your signed-off-by line is odd. I assume your mailer did this to you.
But in case Greg picks it up anyway:

Acked-by Grant Likely <[email protected]>

Quoted 1 line

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Quoted 4 lines

--- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig =A0 2009-02-20 16:41:27.000000000 -0600
+++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c =A0 =A0 =A0 =A02009-03-1=

Quoted 9 lines

09:01:38.994630400 -0500
(quoted diff) +0 -0
@@ -257,7 +257,7 @@ static int __init gfar_mdio_of_init(void
 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gfar_mdio_of_init_one(np);
 
=A0 =A0 =A0 =A0/* try the deprecated version */
- =A0 =A0 =A0 for_each_compatible_node(np, "mdio", "gianfar");
+ =A0 =A0 =A0 for_each_compatible_node(np, "mdio", "gianfar") =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gfar_mdio_of_init_one(np);

Quoted 4 lines

=A0 =A0 =A0 =A0return 0;

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.