Skip to contentSkip to conversation

Screwy arch/x86/include/asm/string_32.h

DISCUSSION David Newall 2 participants 2 messages Mar 14, 2009

lore
Share & tools
lore
#0 lore raw

There's a lot of weirdness in __constant_memcpy in arch/x86/include/asm/string_32.h (2.6.29-rc7).

1. The first switch is missing a case for n equal 7.
2. When n < 20, the four tests (n > 16, n > 12, n > 8 & n > 4) execute identical statements; always 'asm volatile("movsl" :
"=&D"(edi), "=&S"(esi) : "0"(edi), "1"(esi) : "memory")'.

I think it copies less than 4 bytes for values of n between 9 and 19.

#1 lore raw
Quoted 5 lines · David Newall

There's a lot of weirdness in __constant_memcpy in arch/x86/include/asm/string_32.h (2.6.29-rc7).

1. The first switch is missing a case for n equal 7.

That's because there's no way to copy 7 bytes in two operations of 1/2/4 bytes; it would need to be 3 (4+2+1), which I guess the author deemed overly complex.

Quoted 4 lines

2. When n < 20, the four tests (n > 16, n > 12, n > 8 & n > 4) execute identical statements; always 'asm volatile("movsl" :
"=&D"(edi), "=&S"(esi) : "0"(edi), "1"(esi) : "memory")'.

movs is a string instruction which has the side-effect of incrementing esi and edi, so each if() falls through to copy the next 4 bytes.

However, the tail switch should probably use plain "mov" rather than "movs" because nobody uses esi/edi afterwards.

J