Skip to contentSkip to conversation

x86: Add NULL check to lsl

PATCH Applied Jan Kiszka 2 participants 2 messages Mar 16, 2009 – Mar 20, 2009

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 x86: Add NULL check to lsl

According to the Intel specs, lsl performs a check against NULL for the provided selector, just like lar does. helper_lar() includes the corresponding code, helper_lsl() was lacking it so far.

---

 target-i386/op_helper.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
target-i386/op_helper.c +2 -0
index 25e079b..be09263 100644
@@ -3241,6 +3241,8 @@ target_ulong helper_lsl(target_ulong selector1)
 
     selector = selector1 & 0xffff;
     eflags = helper_cc_compute_all(CC_OP);
+    if ((selector & 0xfffc) == 0)
+        goto fail;
     if (load_segment(&e1, &e2, selector) != 0)
         goto fail;
     rpl = selector & 3;
#1 lore raw
Quoted 6 lines · Jan Kiszka

According to the Intel specs, lsl performs a check against NULL for the provided selector, just like lar does. helper_lar() includes the corresponding code, helper_lsl() was lacking it so far.

Applied to trunk and stable. Thanks.

Regards,

Anthony Liguori

Quoted 22 lines

---

 target-i386/op_helper.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
target-i386/op_helper.c +2 -0
index 25e079b..be09263 100644
@@ -3241,6 +3241,8 @@ target_ulong helper_lsl(target_ulong selector1)
 
     selector = selector1 & 0xffff;
     eflags = helper_cc_compute_all(CC_OP);
+    if ((selector & 0xfffc) == 0)
+        goto fail;
     if (load_segment(&e1, &e2, selector) != 0)
         goto fail;
     rpl = selector & 3;