Skip to contentSkip to conversation

kvm-userspace: Fix twisted kvm_arch_get/put_registers

PATCH Applied Jan Kiszka 2 participants 2 messages Mar 16, 2009 – Mar 17, 2009 KVM

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 kvm-userspace: Fix twisted kvm_arch_get/put_registers

[ Get, save, synchronize, put... hell. Reminds me: what's the schedule for finally dropping libkvm? ]

Fix this fallout from recent qemu-trunk merge, it broke guest debugging.

---

 qemu/qemu-kvm.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
qemu/qemu-kvm.h +2 -2
index 4a3ba53..c0549df 100644
@@ -212,12 +212,12 @@ static inline int kvm_sync_vcpus(void) { return 0; }
 
 static inline void kvm_arch_get_registers(CPUState *env)
 {
-    kvm_load_registers(env);
+    kvm_save_registers(env);
 }
 
 static inline void kvm_arch_put_registers(CPUState *env)
 {
-    kvm_save_registers(env);
+    kvm_load_registers(env);
 }
 
 static inline void cpu_synchronize_state(CPUState *env, int modified)
Applied
#1 lore raw
Quoted 4 lines · Jan Kiszka

[ Get, save, synchronize, put... hell. Reminds me: what's the schedule for finally dropping libkvm? ]

Patches welcome.

I expect this will become much easier once qemu merges iothread and smp support. Then we can feed qemu-kvm.c into kvm.c and then into upstream.

Quoted 2 lines

Fix this fallout from recent qemu-trunk merge, it broke guest debugging.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function