ARM: OMAP2: possible division by 0
Subsystems (4)
PATCH 1/1 ARM: OMAP2: possible division by 0
In linus' git tree the functions can be found at:
vi arch/arm/mach-omap2/usb-tusb6010.c +200 - tusb6010_platform_retime()
vi arch/arm/mach-omap2/gpmc.c +94 - gpmc_get_fclk_period()
vi arch/arm/mach-omap2/usb-tusb6010.c +53 - tusb_set_async_mode()
vi arch/arm/mach-omap2/usb-tusb6010.c +111 - tusb_set_sync_mode()
is -ENODEV appropriate when sysclk_ps == 0?
This was found by code analysis, please review. ------------------------------>8-------------8<--------------------------------- gpmc_get_fclk_period() may return 0 when gpmc_l3_clk is not enabled. This is not checked in tusb6010_platform_retime() nor in tusb_set_async_mode() it seems. In tusb_set_sync_mode() this may result in a division by zero.
---
arch/arm/mach-omap2/usb-tusb6010.c +1 -1
@@ -187,7 +187,7 @@ int tusb6010_platform_retime(unsigned is_refclk)unsigned sysclk_ps;int status; -if (!refclk_psec) +if (!refclk_psec || sysclk_ps ==0 )return -ENODEV ; sysclk_ps = is_refclk ? refclk_psec :TUSB6010_OSCCLK_60 ;
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
Tony Lindgren
maintainerPATCH 1/1 ARM: OMAP2: possible division by 0
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Commit: a170fc43065439cff6d18f02a1571a92718b9623
PatchWorks
http://patchwork.kernel.org/patch/12591/
Tony Lindgren
maintainerQuoted 8 lines · Roel Kluin
In linus' git tree the functions can be found at:
viarch/arm/mach-omap2/usb-tusb6010.c+200 -tusb6010_platform_retime()
viarch/arm/mach-omap2/gpmc.c+94 -gpmc_get_fclk_period()
viarch/arm/mach-omap2/usb-tusb6010.c+53 -tusb_set_async_mode()
viarch/arm/mach-omap2/usb-tusb6010.c+111 -tusb_set_sync_mode()is
-ENODEVappropriate whensysclk_ps== 0?
Quoted 7 lines
This was found by code analysis, please review. ------------------------------>8-------------8<---------------------------------
gpmc_get_fclk_period()may return 0 whengpmc_l3_clkis not enabled. This is not checked intusb6010_platform_retime()nor intusb_set_async_mode()it seems. Intusb_set_sync_mode()this may result in a division by zero.Signed-off-by Roel Kluin <[email protected]>
Looks like a valid fix to me. I'll add it to omap-fixes queue. To me it sounds like there's no urgent need to get this integrated as we're missing most of the omap2 PM still.
Tony
Quoted 18 lines
---
arch/arm/mach-omap2/usb-tusb6010.c +1
-2@@ -187,7 +187,7 @@ int tusb6010_platform_retime(unsigned is_refclk)unsigned sysclk_ps;int status; -if (!refclk_psec) +if (!refclk_psec || sysclk_ps ==0 )return -ENODEV ; sysclk_ps = is_refclk ? refclk_psec :TUSB6010_OSCCLK_60 ; --To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html