Skip to contentSkip to conversation

MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2

PATCH Adrian Hunter 2 participants 4 messages Mar 24, 2009 – Mar 25, 2009 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

From a939998e34cbc263317d51b21ab52c8d5863a913 Mon Sep 17 00:00:00 2001

From: Jarkko Lavinen <[email protected]>
Date: Thu, 27 Nov 2008 14:30:32 +0200
Subject: MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2

---
drivers/mmc/core/mmc.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/core/mmc.c +0 -0
index fdd7c76..3f5b089 100644
@@ -208,7 +208,7 @@ static int mmc_read_ext_csd(struct mmc_card *card)
	}

	ext_csd_struct = ext_csd[EXT_CSD_REV];
-	if (ext_csd_struct > 2) {
+	if (ext_csd_struct > 3) {
		printk(KERN_ERR "%s: unrecognised EXT_CSD structure "
			"version %d\n", mmc_hostname(card->host),
			ext_csd_struct);
Signature · 1 line
1.5.4.3
#1 lore raw
Quoted 7 lines · On Tue, 24 Mar 2009 14:12:11 +0200 Adrian Hunter <[email protected]>…

From a939998e34cbc263317d51b21ab52c8d5863a913 Mon Sep 17 00:00:00 2001
From: Jarkko Lavinen <[email protected]>
Date: Thu, 27 Nov 2008 14:30:32 +0200
Subject: MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2

---

I don't like the whole "assuming" part. Do the specs back this up?

Rgds

Signature · 9 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
#2 lore raw
Quoted 8 lines · Pierre Ossman
Quoted 5 lines · On Tue, 24 Mar 2009 14:12:11 +0200 Adrian Hunter <[email protected]>…

From a939998e34cbc263317d51b21ab52c8d5863a913 Mon Sep 17 00:00:00 2001
From: Jarkko Lavinen <[email protected]>
Date: Thu, 27 Nov 2008 14:30:32 +0200
Subject: MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2

Quoted 6 lines
Quoted 2 lines

---

I don't like the whole "assuming" part. Do the specs back this up?

Rgds

Yes.

Please swap "assuming" for "because".

#3 lore raw
Quoted 9 lines · On Wed, 25 Mar 2009 10:05:37 +0200 Adrian Hunter <[email protected]>…
Quoted 4 lines · Pierre Ossman

I don't like the whole "assuming" part. Do the specs back this up?

Rgds

Yes.

Please swap "assuming" for "because".

Ok then. Queued.

Thanks

Signature · 9 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.