Skip to contentSkip to conversation

fs/reiserfs: return f_fsid for statfs(2), v3

PATCH New Coly Li 1 participant 1 message Mar 27, 2009

lore
Share & tools
lore

Coly Li

author
#0 lore raw

PATCH 1/1 fs/reiserfs: return f_fsid for statfs(2), v3

This patch makes reiserfs3 return f_fsid info for statfs(2). By Andreas' suggestion, this patch populates a persistent f_fsid between boots/mounts with help of on-disk uuid record.

Randy Dunlap reported a compiling error from v2 patch like:

    fs/built-in.o: In function `reiserfs_statfs':
    super.c:(.text+0x7332b): undefined reference to `crc32_le'
    super.c:(.text+0x7333f): undefined reference to `crc32_le'

Also he provided helpful solution to fix this error. The modification of v3 patch is based on Randy's suggestion, add 'select CRC32' in fs/reiserfs/Kconfig.

---
 fs/reiserfs/Kconfig |    1 +
 fs/reiserfs/super.c |    5 +++++
 2 files changed, 6 insertions(+), 0 deletions(-)
fs/reiserfs/Kconfig +1 -0
index 949b8c6..513f431 100644
@@ -1,5 +1,6 @@
 config REISERFS_FS
 	tristate "Reiserfs support"
+	select CRC32
 	help
 	  Stores not just filenames but the files themselves in a balanced
 	  tree.  Uses journalling.
fs/reiserfs/super.c +1 -0
index f3c820b..cb8e7ee 100644
@@ -27,6 +27,7 @@
 #include <linux/mnt_namespace.h>
 #include <linux/mount.h>
 #include <linux/namei.h>
+#include <linux/crc32.h>
 
 struct file_system_type reiserfs_fs_type;
 
@@ -1892,6 +1893,10 @@ static int reiserfs_statfs(struct dentry *dentry, struct

kstatfs *buf)
buf->f_bsize = dentry->d_sb->s_blocksize;
/* changed to accommodate gcc folks. */
buf->f_type = REISERFS_SUPER_MAGIC;
+ buf->f_fsid.val[0] = (u32)crc32_le(0, rs->s_uuid, sizeof(rs->s_uuid)/2);
+ buf->f_fsid.val[1] = (u32)crc32_le(0, rs->s_uuid + sizeof(rs->s_uuid)/2,
+ sizeof(rs->s_uuid)/2);
+
return 0;
}

Signature · 2 lines
Coly Li
SuSE Labs