Skip to contentSkip to conversation

UIO: uio_mem does not handle devices above 4 GB address

DISCUSSION Steven A. Falco 2 participants 2 messages Apr 2, 2009 – Jun 16, 2009

lore
Share & tools
lore
#0 lore raw
Quoted 3 lines · Luis
Quoted 2 lines
Quoted 2 lines

I am working on a PPC440EPx board with some FPGAs located at addresses above 4 GB

Cc'ing the PPC list, since they have the most experience with this CPU, and may have some useful insights. The topic is "UIO on the PPC440EPx - 36-bit physical addresses".

The PPC440EPx uses 36-bit addressing but is a 32-bit processor. *All* peripherals are above the first 4 GB - that cannot be changed if you use this CPU chip.

In general, the solution is to use "struct resource" to carry physical addresses and sizes. The basic type is:

#ifdef CONFIG_PHYS_ADDR_T_64BIT
typedef u64 phys_addr_t;
#else
typedef u32 phys_addr_t;
#endif

and for this processor, we use u64 rather than u32.

So, if we want to make UIO usable on this class of CPU, we might replace:

struct uio_mem {
	unsigned long		addr;
	unsigned long		size;
	int			memtype;
	void __iomem		*internal_addr;
	struct uio_map		*map;
};

with:

struct uio_mem {
	phys_addr_t		addr;
	phys_addr_t		size;
	int			memtype;
	void __iomem		*internal_addr;
	struct uio_map		*map;
};

A few other changes would be needed. We'd have to use something other than

	return sprintf(buf, "0x%lx\n", mem->addr);

because the format would be incorrect for a u64. Also, I believe we would get warnings in uio_vma_fault(). However, the phys_addr is really only applicable to UIO_MEM_PHYS, so perhaps we want a union of phys_addr_t and unsigned long for addr and size?

Anyway, this is a real problem for the PPC440EPx, that board designers cannot work around.

Steve

#1 lore raw
Quoted 10 lines · Steven A. Falco
struct uio_mem {
	phys_addr_t		addr;
	phys_addr_t		size;
	int			memtype;
	void __iomem		*internal_addr;
	struct uio_map		*map;
};

A few other changes would be needed. We'd have to use something other than

Use a struct resource instead.

Quoted 2 lines
	return sprintf(buf, "0x%lx\n", mem->addr);

The struct resource has a printk format string.

Cheers,
Ben.

Quoted 4 lines

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev