Skip to contentSkip to conversation

GPIO: OMAP: Fixed spurious IRQ issue for GPIO interrupts

PATCH New Roger Quadros 2 participants 2 messages Apr 3, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 GPIO: OMAP: Fixed spurious IRQ issue for GPIO interrupts

From: Roger Quadros <[email protected]>
Date: Fri, 3 Apr 2009 10:32:20 +0300
Subject: [PATCH] GPIO: OMAP: Fixed spurious IRQ issue for GPIO interrupts

Flush posted write to IRQSTATUS register in GPIO IRQ handler. This eliminates the below error for all peripherals that use GPIO interrupts.

<4>Spurious irq 95: 0xffffffdf, please flush posted write for irq 31

---
arch/arm/plat-omap/gpio.c | 6 +++++-

1 files changed, 5 insertions(+), 1 deletions(-)
arch/arm/plat-omap/gpio.c +0 -0
index 210a1c0..17d7afe 100644
@@ -758,8 +758,12 @@ static void _clear_gpio_irqbank(struct gpio_bank *bank, int gpio_mask)
 
	/* Workaround for clearing DSP GPIO interrupts to allow retention */
#if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
+	reg = bank->base + OMAP24XX_GPIO_IRQSTATUS2;
	if (cpu_is_omap24xx() || cpu_is_omap34xx())

- __raw_writel(gpio_mask, bank->base + OMAP24XX_GPIO_IRQSTATUS2);
+ __raw_writel(gpio_mask, reg);
+
+ /* Flush posted write for the irq status to avoid spurious interrupts */
+ __raw_readl(reg);
#endif
}

Signature · 1 line
1.5.6.5