Fix paramater/parameter typo in dmesg and source comments

PATCH In review Martin Olsson 2 participants 4 messages Apr 4, 2009

Subsystems (13)

Network drivers SCSI USB Staging +9 more subsystems

lore

Share & tools

lore

Martin Olsson

author

2009-04-04 10:49 UTC #0 lore raw

PATCH 2/2 Fix paramater/parameter typo in dmesg and source comments

From edef040c17106bb02431b9399e9b214da8d7a5fd Mon Sep 17 00:00:00 2001
From: Martin Olsson <[email protected]>
Date: Sat, 4 Apr 2009 12:29:59 +0200
Subject: [PATCH] Correctly spell the word "parameter" in various source comments.

Signed-off-by Martin Olsson <[email protected]>

---
 drivers/atm/lanai.c                    |    2 +-
 drivers/input/joystick/xpad.c          |    2 +-
 drivers/net/b44.c                      |    2 +-
 drivers/net/smc-mca.c                  |    2 +-
 drivers/net/wireless/orinoco/orinoco.h |    2 +-
 drivers/net/wireless/p54/p54spi.c      |    2 +-
 drivers/scsi/qla1280.c                 |    2 +-
 drivers/scsi/qla4xxx/ql4_mbx.c         |    2 +-
 drivers/staging/epl/EplInstDef.h       |    2 +-
 drivers/staging/rt2860/rt28xx.h        |    2 +-
 drivers/staging/rt2870/rt28xx.h        |    2 +-
 drivers/usb/core/message.c             |    4 ++--
 drivers/usb/serial/io_edgeport.c       |    2 +-
 drivers/usb/serial/ir-usb.c            |    2 +-
 drivers/video/controlfb.c              |    2 +-
 fs/debugfs/inode.c                     |    6 +++---
 16 files changed, 19 insertions(+), 19 deletions(-)

drivers/atm/lanai.c +1 -1

index 8733a2e..df6753e 100644
@@ -66,7 +66,7 @@
 #include <linux/delay.h>
 #include <linux/interrupt.h>
 
-/* -------------------- TUNABLE PARAMATERS: */
+/* -------------------- TUNABLE PARAMETERS: */
 
 /*
  * Maximum number of VCIs per card.  Setting it lower could theoretically

drivers/input/joystick/xpad.c +1 -1

index b868b8d..32dfada 100644
@@ -66,7 +66,7 @@
  *  - borrowed from the XBOX linux kernel
  *  - USB id's for commonly used dance pads are present
  *  - dance pads will map D-PAD to buttons, not axes
- *  - pass the module paramater 'dpad_to_buttons' to force
+ *  - pass the module parameter 'dpad_to_buttons' to force
  *    the D-PAD to map to buttons if your pad is not detected
  *
  * Later changes can be tracked in SCM.

drivers/net/b44.c +1 -1

index 5c84541..230c13c 100644
@@ -2343,7 +2343,7 @@ static int __init b44_init(void)
 	unsigned int dma_desc_align_size = dma_get_cache_alignment();
 	int err;
 
-	/* Setup paramaters for syncing RX/TX DMA descriptors */
+	/* Setup parameters for syncing RX/TX DMA descriptors */
 	dma_desc_align_mask = ~(dma_desc_align_size - 1);
 	dma_desc_sync_size = max_t(unsigned int, dma_desc_align_size, sizeof(struct dma_desc));

drivers/net/smc-mca.c +1 -1

index 8d36d40..568658e 100644
@@ -240,7 +240,7 @@ static int __init ultramca_probe(struct device *gen_dev)
 	/* Test the following conditions:
 	 * - If an irq parameter is supplied, compare it
 	 *   with the irq of the adapter we found
-	 * - If a base_addr paramater is given, compare it
+	 * - If a base_addr parameter is given, compare it
 	 *   with the base_addr of the adapter we found
 	 * - Check that the irq and the base_addr of the
 	 *   adapter we found is not already in use by

drivers/net/wireless/orinoco/orinoco.h +1 -1

index 8e5a72c..5df7837 100644
@@ -115,7 +115,7 @@ struct orinoco_private {
 	unsigned int broken_disableport:1;
 	unsigned int broken_monitor:1;
 
-	/* Configuration paramaters */
+	/* Configuration parameters */
 	u32 iw_mode;
 	int prefer_port3;
 	u16 encode_alg, wep_restrict, tx_key;

drivers/net/wireless/p54/p54spi.c +1 -1

index 2b222aa..b83a7b4 100644
@@ -42,7 +42,7 @@ MODULE_ALIAS("stlc45xx");
 /*
  * gpios should be handled in board files and provided via platform data,
  * but because it's currently impossible for p54spi to have a header file
- * in include/linux, let's use module paramaters for now
+ * in include/linux, let's use module parameters for now
  */
 
 static int p54spi_gpio_power = 97;

drivers/scsi/qla1280.c +1 -1

index df09820..a1fc449 100644
@@ -4326,7 +4326,7 @@ qla1280_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 		goto error_release_region;
 	}
 
-	/* load the F/W, read paramaters, and init the H/W */
+	/* load the F/W, read parameters, and init the H/W */
 	if (qla1280_initialize_adapter(ha)) {
 		printk(KERN_INFO "qla1x160: Failed to initialize adapter\n");
 		goto error_free_irq;

drivers/scsi/qla4xxx/ql4_mbx.c +1 -1

index 051b0f5..cd18028 100644
@@ -250,7 +250,7 @@ int qla4xxx_initialize_fw_cb(struct scsi_qla_host * ha)
 	/*memcpy(ha->alias, init_fw_cb->Alias,
 	       min(sizeof(ha->alias), sizeof(init_fw_cb->Alias)));*/
 
-	/* Save Command Line Paramater info */
+	/* Save Command Line Parameter info */
 	ha->port_down_retry_count = le16_to_cpu(init_fw_cb->pri.conn_ka_timeout);
 	ha->discovery_wait = ql4xdiscoverywait;

drivers/staging/epl/EplInstDef.h +1 -1

index 89efbf2..1f2fd2e 100644
@@ -163,7 +163,7 @@ typedef BYTE tEplInstanceHdl;
     //--------------------------------------------------------------------------------------
 
     // macros for declaration within the function header, prototype or local var list
-    // Declaration of pointers within function paramater list must defined as void MEM*
+    // Declaration of pointers within function parameter list must defined as void MEM*
     // pointer.
 #define EPL_MCO_DECL_INSTANCE_PTR                   void MEM* pInstance
 #define EPL_MCO_DECL_INSTANCE_PTR_                  void MEM* pInstance,

drivers/staging/rt2860/rt28xx.h +1 -1

index ff23043..eefc7db 100644
@@ -1063,7 +1063,7 @@ typedef	union	_LG_FBK_CFG1_STRUC	{
 #endif
 
 //=======================================================
-//================ Protection Paramater================================
+//================ Protection Parameter================================
 //=======================================================
 #define CCK_PROT_CFG	0x1364		//CCK Protection
 #define ASIC_SHORTNAV		1

drivers/staging/rt2870/rt28xx.h +1 -1

index 3927d22..9a9b708 100644
@@ -1063,7 +1063,7 @@ typedef	union	_LG_FBK_CFG1_STRUC	{
 #endif
 
 //=======================================================
-//================ Protection Paramater================================
+//================ Protection Parameter================================
 //=======================================================
 #define CCK_PROT_CFG	0x1364		//CCK Protection
 #define ASIC_SHORTNAV		1

drivers/usb/core/message.c +2 -2

index 30a0690..435e43e 100644
@@ -172,7 +172,7 @@ EXPORT_SYMBOL_GPL(usb_control_msg);
  * waits for the message to complete, or timeout.
  *
  * If successful, it returns 0, otherwise a negative error number.  The number
- * of actual bytes transferred will be stored in the actual_length paramater.
+ * of actual bytes transferred will be stored in the actual_length parameter.
  *
  * Don't use this function from within an interrupt context, like a bottom half
  * handler.  If you need an asynchronous message, or need to send a message

@@ -205,7 +205,7 @@ EXPORT_SYMBOL_GPL(usb_interrupt_msg);
  * and waits for the message to complete, or timeout.
  *
  * If successful, it returns 0, otherwise a negative error number.  The number
- * of actual bytes transferred will be stored in the actual_length paramater.
+ * of actual bytes transferred will be stored in the actual_length parameter.
  *
  * Don't use this function from within an interrupt context, like a bottom half
  * handler.  If you need an asynchronous message, or need to send a message

drivers/usb/serial/io_edgeport.c +1 -1

index e85c8c0..a242ef5 100644
@@ -151,7 +151,7 @@ struct edgeport_serial {
 	__u8			rxHeader3;			/* receive header byte 3 */
 	__u8			rxPort;				/* the port that we are currently receiving data for */
 	__u8			rxStatusCode;			/* the receive status code */
-	__u8			rxStatusParam;			/* the receive status paramater */
+	__u8			rxStatusParam;			/* the receive status parameter */
 	__s16			rxBytesRemaining;		/* the number of port bytes left to read */
 	struct usb_serial	*serial;			/* loop back to the owner of this object */
 };

drivers/usb/serial/ir-usb.c +1 -1

index 4e2cda9..bf4e2f3 100644
@@ -47,7 +47,7 @@
  *
  * 2001_Nov_01	greg kh
  *	Added support for more IrDA USB devices.
- *	Added support for zero packet.  Added buffer override paramater, so
+ *	Added support for zero packet.  Added buffer override parameter, so
  *	users can transfer larger packets at once if they wish.  Both patches
  *	came from Dag Brattli <[email protected]>.
  *

drivers/video/controlfb.c +1 -1

index 49fcbe8..b8929d3 100644
@@ -792,7 +792,7 @@ static int read_control_sense(struct fb_info_control *p)
 #define CONTROL_PIXCLOCK_MIN	5000	/* ~ 200 MHz dot clock */
 
 /*
- * calculate the clock paramaters to be sent to CUDA according to given
+ * calculate the clock parameters to be sent to CUDA according to given
  * pixclock in pico second.
  */
 static int calc_clock_params(unsigned long clk, unsigned char *param)

fs/debugfs/inode.c +3 -3

index 81ae9ea..9a6f88b 100644
@@ -185,7 +185,7 @@ static int debugfs_create_by_name(const char *name, mode_t mode,
  * @name: a pointer to a string containing the name of the file to create.
  * @mode: the permission that the file should have
  * @parent: a pointer to the parent dentry for this file.  This should be a
- *          directory dentry if set.  If this paramater is NULL, then the
+ *          directory dentry if set.  If this parameter is NULL, then the
  *          file will be created in the root of the debugfs filesystem.
  * @data: a pointer to something that the caller will want to get to later
  *        on.  The inode.i_private pointer will point to this value on

@@ -243,7 +243,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_file);
  * @name: a pointer to a string containing the name of the directory to
  *        create.
  * @parent: a pointer to the parent dentry for this file.  This should be a
- *          directory dentry if set.  If this paramater is NULL, then the
+ *          directory dentry if set.  If this parameter is NULL, then the
  *          directory will be created in the root of the debugfs filesystem.
  *
  * This function creates a directory in debugfs with the given name.

@@ -269,7 +269,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_dir);
  * @name: a pointer to a string containing the name of the symbolic link to
  *        create.
  * @parent: a pointer to the parent dentry for this symbolic link.  This
- *          should be a directory dentry if set.  If this paramater is NULL,
+ *          should be a directory dentry if set.  If this parameter is NULL,
  *          then the symbolic link will be created in the root of the debugfs
  *          filesystem.
  * @target: a pointer to a string containing the path to the target of the

Signature · 1 line

1.6.0.4

Signed-off-by Martin Olsson <[email protected]>

---
 drivers/atm/lanai.c                    |    2 +-
 drivers/input/joystick/xpad.c          |    2 +-
 drivers/net/b44.c                      |    2 +-
 drivers/net/smc-mca.c                  |    2 +-
 drivers/net/wireless/orinoco/orinoco.h |    2 +-
 drivers/net/wireless/p54/p54spi.c      |    2 +-
 drivers/scsi/qla1280.c                 |    2 +-
 drivers/scsi/qla4xxx/ql4_mbx.c         |    2 +-
 drivers/staging/epl/EplInstDef.h       |    2 +-
 drivers/staging/rt2860/rt28xx.h        |    2 +-
 drivers/staging/rt2870/rt28xx.h        |    2 +-
 drivers/usb/core/message.c             |    4 ++--
 drivers/usb/serial/io_edgeport.c       |    2 +-
 drivers/usb/serial/ir-usb.c            |    2 +-
 drivers/video/controlfb.c              |    2 +-
 fs/debugfs/inode.c                     |    6 +++---
 16 files changed, 19 insertions(+), 19 deletions(-)

drivers/atm/lanai.c +1 -1

index 8733a2e..df6753e 100644
@@ -66,7 +66,7 @@
 #include <linux/delay.h>
 #include <linux/interrupt.h>
 
-/* -------------------- TUNABLE PARAMATERS: */
+/* -------------------- TUNABLE PARAMETERS: */
 
 /*
  * Maximum number of VCIs per card.  Setting it lower could theoretically

drivers/input/joystick/xpad.c +1 -1

index b868b8d..32dfada 100644
@@ -66,7 +66,7 @@
  *  - borrowed from the XBOX linux kernel
  *  - USB id's for commonly used dance pads are present
  *  - dance pads will map D-PAD to buttons, not axes
- *  - pass the module paramater 'dpad_to_buttons' to force
+ *  - pass the module parameter 'dpad_to_buttons' to force
  *    the D-PAD to map to buttons if your pad is not detected
  *
  * Later changes can be tracked in SCM.

drivers/net/b44.c +1 -1

index 5c84541..230c13c 100644
@@ -2343,7 +2343,7 @@ static int __init b44_init(void)
 	unsigned int dma_desc_align_size = dma_get_cache_alignment();
 	int err;
 
-	/* Setup paramaters for syncing RX/TX DMA descriptors */
+	/* Setup parameters for syncing RX/TX DMA descriptors */
 	dma_desc_align_mask = ~(dma_desc_align_size - 1);
 	dma_desc_sync_size = max_t(unsigned int, dma_desc_align_size, sizeof(struct dma_desc));

drivers/net/smc-mca.c +1 -1

index 8d36d40..568658e 100644
@@ -240,7 +240,7 @@ static int __init ultramca_probe(struct device *gen_dev)
 	/* Test the following conditions:
 	 * - If an irq parameter is supplied, compare it
 	 *   with the irq of the adapter we found
-	 * - If a base_addr paramater is given, compare it
+	 * - If a base_addr parameter is given, compare it
 	 *   with the base_addr of the adapter we found
 	 * - Check that the irq and the base_addr of the
 	 *   adapter we found is not already in use by

drivers/net/wireless/orinoco/orinoco.h +1 -1

index 8e5a72c..5df7837 100644
@@ -115,7 +115,7 @@ struct orinoco_private {
 	unsigned int broken_disableport:1;
 	unsigned int broken_monitor:1;
 
-	/* Configuration paramaters */
+	/* Configuration parameters */
 	u32 iw_mode;
 	int prefer_port3;
 	u16 encode_alg, wep_restrict, tx_key;

drivers/net/wireless/p54/p54spi.c +1 -1

index 2b222aa..b83a7b4 100644
@@ -42,7 +42,7 @@ MODULE_ALIAS("stlc45xx");
 /*
  * gpios should be handled in board files and provided via platform data,
  * but because it's currently impossible for p54spi to have a header file
- * in include/linux, let's use module paramaters for now
+ * in include/linux, let's use module parameters for now
  */
 
 static int p54spi_gpio_power = 97;

drivers/scsi/qla1280.c +1 -1

index df09820..a1fc449 100644
@@ -4326,7 +4326,7 @@ qla1280_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 		goto error_release_region;
 	}
 
-	/* load the F/W, read paramaters, and init the H/W */
+	/* load the F/W, read parameters, and init the H/W */
 	if (qla1280_initialize_adapter(ha)) {
 		printk(KERN_INFO "qla1x160: Failed to initialize adapter\n");
 		goto error_free_irq;

drivers/scsi/qla4xxx/ql4_mbx.c +1 -1

index 051b0f5..cd18028 100644
@@ -250,7 +250,7 @@ int qla4xxx_initialize_fw_cb(struct scsi_qla_host * ha)
 	/*memcpy(ha->alias, init_fw_cb->Alias,
 	       min(sizeof(ha->alias), sizeof(init_fw_cb->Alias)));*/
 
-	/* Save Command Line Paramater info */
+	/* Save Command Line Parameter info */
 	ha->port_down_retry_count = le16_to_cpu(init_fw_cb->pri.conn_ka_timeout);
 	ha->discovery_wait = ql4xdiscoverywait;

drivers/staging/epl/EplInstDef.h +1 -1

index 89efbf2..1f2fd2e 100644
@@ -163,7 +163,7 @@ typedef BYTE tEplInstanceHdl;
     //--------------------------------------------------------------------------------------
 
     // macros for declaration within the function header, prototype or local var list
-    // Declaration of pointers within function paramater list must defined as void MEM*
+    // Declaration of pointers within function parameter list must defined as void MEM*
     // pointer.
 #define EPL_MCO_DECL_INSTANCE_PTR                   void MEM* pInstance
 #define EPL_MCO_DECL_INSTANCE_PTR_                  void MEM* pInstance,

drivers/staging/rt2860/rt28xx.h +1 -1

index ff23043..eefc7db 100644
@@ -1063,7 +1063,7 @@ typedef	union	_LG_FBK_CFG1_STRUC	{
 #endif
 
 //=======================================================
-//================ Protection Paramater================================
+//================ Protection Parameter================================
 //=======================================================
 #define CCK_PROT_CFG	0x1364		//CCK Protection
 #define ASIC_SHORTNAV		1

drivers/staging/rt2870/rt28xx.h +1 -1

index 3927d22..9a9b708 100644
@@ -1063,7 +1063,7 @@ typedef	union	_LG_FBK_CFG1_STRUC	{
 #endif
 
 //=======================================================
-//================ Protection Paramater================================
+//================ Protection Parameter================================
 //=======================================================
 #define CCK_PROT_CFG	0x1364		//CCK Protection
 #define ASIC_SHORTNAV		1

drivers/usb/core/message.c +2 -2

index 30a0690..435e43e 100644
@@ -172,7 +172,7 @@ EXPORT_SYMBOL_GPL(usb_control_msg);
  * waits for the message to complete, or timeout.
  *
  * If successful, it returns 0, otherwise a negative error number.  The number
- * of actual bytes transferred will be stored in the actual_length paramater.
+ * of actual bytes transferred will be stored in the actual_length parameter.
  *
  * Don't use this function from within an interrupt context, like a bottom half
  * handler.  If you need an asynchronous message, or need to send a message

@@ -205,7 +205,7 @@ EXPORT_SYMBOL_GPL(usb_interrupt_msg);
  * and waits for the message to complete, or timeout.
  *
  * If successful, it returns 0, otherwise a negative error number.  The number
- * of actual bytes transferred will be stored in the actual_length paramater.
+ * of actual bytes transferred will be stored in the actual_length parameter.
  *
  * Don't use this function from within an interrupt context, like a bottom half
  * handler.  If you need an asynchronous message, or need to send a message

drivers/usb/serial/io_edgeport.c +1 -1

index e85c8c0..a242ef5 100644
@@ -151,7 +151,7 @@ struct edgeport_serial {
 	__u8			rxHeader3;			/* receive header byte 3 */
 	__u8			rxPort;				/* the port that we are currently receiving data for */
 	__u8			rxStatusCode;			/* the receive status code */
-	__u8			rxStatusParam;			/* the receive status paramater */
+	__u8			rxStatusParam;			/* the receive status parameter */
 	__s16			rxBytesRemaining;		/* the number of port bytes left to read */
 	struct usb_serial	*serial;			/* loop back to the owner of this object */
 };

drivers/usb/serial/ir-usb.c +1 -1

index 4e2cda9..bf4e2f3 100644
@@ -47,7 +47,7 @@
  *
  * 2001_Nov_01	greg kh
  *	Added support for more IrDA USB devices.
- *	Added support for zero packet.  Added buffer override paramater, so
+ *	Added support for zero packet.  Added buffer override parameter, so
  *	users can transfer larger packets at once if they wish.  Both patches
  *	came from Dag Brattli <[email protected]>.
  *

drivers/video/controlfb.c +1 -1

index 49fcbe8..b8929d3 100644
@@ -792,7 +792,7 @@ static int read_control_sense(struct fb_info_control *p)
 #define CONTROL_PIXCLOCK_MIN	5000	/* ~ 200 MHz dot clock */
 
 /*
- * calculate the clock paramaters to be sent to CUDA according to given
+ * calculate the clock parameters to be sent to CUDA according to given
  * pixclock in pico second.
  */
 static int calc_clock_params(unsigned long clk, unsigned char *param)

fs/debugfs/inode.c +3 -3

index 81ae9ea..9a6f88b 100644
@@ -185,7 +185,7 @@ static int debugfs_create_by_name(const char *name, mode_t mode,
  * @name: a pointer to a string containing the name of the file to create.
  * @mode: the permission that the file should have
  * @parent: a pointer to the parent dentry for this file.  This should be a
- *          directory dentry if set.  If this paramater is NULL, then the
+ *          directory dentry if set.  If this parameter is NULL, then the
  *          file will be created in the root of the debugfs filesystem.
  * @data: a pointer to something that the caller will want to get to later
  *        on.  The inode.i_private pointer will point to this value on

@@ -243,7 +243,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_file);
  * @name: a pointer to a string containing the name of the directory to
  *        create.
  * @parent: a pointer to the parent dentry for this file.  This should be a
- *          directory dentry if set.  If this paramater is NULL, then the
+ *          directory dentry if set.  If this parameter is NULL, then the
  *          directory will be created in the root of the debugfs filesystem.
  *
  * This function creates a directory in debugfs with the given name.

@@ -269,7 +269,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_dir);
  * @name: a pointer to a string containing the name of the symbolic link to
  *        create.
  * @parent: a pointer to the parent dentry for this symbolic link.  This
- *          should be a directory dentry if set.  If this paramater is NULL,
+ *          should be a directory dentry if set.  If this parameter is NULL,
  *          then the symbolic link will be created in the root of the debugfs
  *          filesystem.
  * @target: a pointer to a string containing the path to the target of the

Signature · 1 line

1.6.0.4

Robert P. J. Day

2009-04-04 12:08 UTC #1 lore raw

Re: [PATCH 2/2] Fix paramater/parameter typo in dmesg and source

Quoted 17 lines · Martin Olsson

From edef040c17106bb02431b9399e9b214da8d7a5fd Mon Sep 17 00:00:00 2001
From: Martin Olsson <[email protected]>
Date: Sat, 4 Apr 2009 12:29:59 +0200
Subject: [PATCH] Correctly spell the word "parameter" in various source comments.
Signed-off-by Martin Olsson <[email protected]>
---
 drivers/atm/lanai.c                    |    2 +-
 drivers/input/joystick/xpad.c          |    2 +-
 drivers/net/b44.c                      |    2 +-
 drivers/net/smc-mca.c                  |    2 +-
 drivers/net/wireless/orinoco/orinoco.h |    2 +-
 drivers/net/wireless/p54/p54spi.c      |    2 +-
 drivers/scsi/qla1280.c                 |    2 +-
 drivers/scsi/qla4xxx/ql4_mbx.c         |    2 +-
 drivers/staging/epl/EplInstDef.h       |    2 +-

Quoted 8 lines

 drivers/staging/rt2860/rt28xx.h        |    2 +-
 drivers/staging/rt2870/rt28xx.h        |    2 +-
 drivers/usb/core/message.c             |    4 ++--
 drivers/usb/serial/io_edgeport.c       |    2 +-
 drivers/usb/serial/ir-usb.c            |    2 +-
 drivers/video/controlfb.c              |    2 +-
 fs/debugfs/inode.c                     |    6 +++---
 16 files changed, 19 insertions(+), 19 deletions(-)

just FYI, that doesn't appear to be all of them:

drivers/net/wireless/rndis_wlan.c: devdbg(dev, "setting rndis config paramater failed, %d.", ret);

might be worth making another pass. and while you're at it, you might grep for what i've noticed is a *very* common misspelling:
"paramter". i'm betting you'll find at least a few of those.

rday
--

====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
====================================

Martin Olsson

author

2009-04-04 12:21 UTC #2 lore raw

Re: [PATCH 2/2] Fix paramater/parameter typo in dmesg and source

In reply to Martin Olsson

Quoted 5 lines · Robert P. J. Day

drivers/net/wireless/rndis_wlan.c: devdbg(dev, "setting rndis config paramater failed, %d.", ret);
might be worth making another pass. and while you're at it, you might grep for what i've noticed is a *very* common misspelling:
"paramter". i'm betting you'll find at least a few of those.

I've covered all instances found by grep already except one but that one was inside a changelog and I didn't want to change that retrospectively. I split them up into one patch for all source comment changes and another patch for the debug print outs to dmesg etc.

The one you mention here is already covered by the debug print patch.

As you suspected, paramter is even more common in the kernel dev vocabulary :) I might do the some more patches later if the first ones are well received / pushed.

Martin

Robert P. J. Day

2009-04-04 12:29 UTC #3 lore raw

Re: [PATCH 2/2] Fix paramater/parameter typo in dmesg and source

In reply to Martin Olsson

Quoted 8 lines · Martin Olsson

Quoted 6 lines · Robert P. J. Day
drivers/net/wireless/rndis_wlan.c: devdbg(dev, "setting rndis config
paramater failed, %d.", ret);
might be worth making another pass. and while you're at it, you might grep for what i've noticed is a *very* common misspelling:
"paramter". i'm betting you'll find at least a few of those.

Quoted 7 lines

I've covered all instances found by grep already except one but that one was inside a changelog and I didn't want to change that retrospectively. I split them up into one patch for all source comment changes and another patch for the debug print outs to dmesg etc.
The one you mention here is already covered by the debug print patch.

ah, i hadn't noticed that earlier patch, sorry.

Quoted 3 lines

As you suspected, paramter is even more common in the kernel dev vocabulary :) I might do the some more patches later if the first ones are well received / pushed.

in cases where there are a combination of typoes in both innocuous
comments and actual code (debug msgs, for example), it might be worth making those corrections in two passes:

1) harmless fixes in things like comments can go to [email protected]

2) non-trivial fixes to janitors list

or maybe that's overkill. it's even possible that, with that many fixes, you correct stuff on a subsystem-by-subsystem basis to keep the patch sizes manageable and, for each patch, CC the subsystem list.

rday
--

====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
====================================