ARM: OMAP: Fix path for omap-sha1-md5 import of irqs.h
PATCH 1/1 ARM: OMAP: Fix path for omap-sha1-md5 import of irqs.h
Hi there,
This is my first kernel-type patch, so please go easy on me if I've made any mistakes. I recently tried building the master kernel from master (commit e75343a207ef24490176abe3503743d7a006e299) and it failed atomap-sha1-md5.c with a file not found issue (asm/arch-omap/irqs.h). I
looked for a similar file, and figured that it meant asm/plat-omap/include/mach/irqs.h, so I produced the patch below. Hopefully that's the correct solution, but I'd appreciate it if someone else could look it over too. Thanks very much,
Mike 5:)
--- drivers/crypto/omap-sha1-md5.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/crypto/omap-sha1-md5.c +1 -1
@@ -13,7 +13,7 @@* This driver is based on padlock-sha.c driver. */ -#include <asm/arch-omap/irqs.h> +#include <mach/irqs.h> #include <crypto/algapi.h> #include <crypto/sha.h> #include <linux/err.h>
Signature · 1 line
1.6.2.2
Hi,
Quoted 10 lines · Mike Auty
Hi there,
This is my first kernel-type patch, so please go easy on me if I've made any mistakes. I recently tried building the master kernel from master (commit
e75343a207ef24490176abe3503743d7a006e299) and it failed atomap-sha1-md5.cwith a file not found issue (asm/arch-omap/irqs.h). I
looked for a similar file, and figured that it meantasm/plat-omap/include/mach/irqs.h, so I produced the patch below. Hopefully that's the correct solution, but I'd appreciate it if someone else could look it over too. Thanks very much,
Sorry for the delay.. I'll apply this to linux-omap tree. Do you want to take this driver and prepare a patch to the associated driver mailing list so we can get it integrated?
Regards,
Tony
Quoted 26 lines
Mike 5:)
--- drivers/crypto/omap-sha1-md5.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/crypto/omap-sha1-md5.c +1
-1@@ -13,7 +13,7 @@* This driver is based on padlock-sha.c driver. */ -#include <asm/arch-omap/irqs.h> +#include <mach/irqs.h> #include <crypto/algapi.h> #include <crypto/sha.h> #include <linux/err.h> Signature · 6 lines
1.6.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/1 ARM: OMAP: Fix path for omap-sha1-md5 import of irqs.h
In reply to Mike AutyThis patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Initial commit ID (Likely to change): 2e4a0b9ddbc1c788d20321b5b8fdf4c1c20baf07
PatchWorks
http://patchwork.kernel.org/patch/16356/
Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=2e4a0b9ddbc1c788d20321b5b8fdf4c1c20baf07
Quoted 3 lines
Sorry for the delay.. I'll apply this to linux-omap tree. Do you want to take this driver and prepare a patch to the associated driver mailing list so we can get it integrated?
Errr, I'm not sure what that entails? What would I have to do? It's really such a trivial fix, I wasn't sure it needed a patch at all. I can do something extra if that's necessary, but I was really just reporting it since I thought someone should know...
Mike 5:)
Quoted 8 lines · Mike Auty
Quoted 3 lines
Sorry for the delay.. I'll apply this to linux-omap tree. Do you want to take this driver and prepare a patch to the associated driver mailing list so we can get it integrated?
Errr, I'm not sure what that entails? What would I have to do? It's really such a trivial fix, I wasn't sure it needed a patch at all. I can do something extra if that's necessary, but I was really just reporting it since I thought someone should know...
Well if you want to do some Linux stuff that's a good way to get started :)
Just see who maintains the those kind of drivers and prepare the patch against mainline tree and send it to the maintainer with the right driver mailing list Cc'd and linux-omap list Cc'd. Then fix the comments if needed. That's all it takes. Be sure to read Documentation/Submit* files, and run your patch through checkpatch.pl first..
Tony