Skip to contentSkip to conversation

vg mempool: fix activation code

PATCH New Milan Broz 2 participants 2 messages Apr 6, 2009 – Apr 7, 2009

lore
Share & tools
lore

Milan Broz

author
#0 lore raw

PATCH 3/6 vg mempool: fix activation code

Properly release VG memory pool in activation code and clvmd.

---
 daemons/clvmd/lvm-functions.c |    1 +
 lib/activate/activate.c       |  120 +++++++++++++++++++++++++++--------------
 2 files changed, 80 insertions(+), 41 deletions(-)
daemons/clvmd/lvm-functions.c +1 -0
index 4fc8613..6509bc2 100644
@@ -724,6 +724,7 @@ void lvm_do_backup(const char *vgname)
 	else
 		log_error("Error backing up metadata, can't find VG for group %s", vgname);
 
+	vg_release(vg);
 	dm_pool_empty(cmd->mem);
 
 	pthread_mutex_unlock(&lvm_lock);
lib/activate/activate.c +79 -41

258 lines not on this page · raw message

#1 lore raw

PATCH 3/6 vg mempool: fix activation code

Quoted 3 lines · Milan Broz

Properly release VG memory pool in activation code and clvmd.

No particular comments. Lots of code path shuffling, I have read through all of it and I believe it's all equivalent, plus it calls vg_release when needed, as advertised.

Yours,
Petr.

Signature · 6 lines
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation