Skip to contentSkip to conversation

qla1280: driver clean up, error recovery rewrite

PATCH In review Michael Reed 2 participants 2 messages Apr 8, 2009 – Apr 9, 2009 SCSI

lore
Share & tools
lore
#0 lore raw

cover qla1280: driver clean up, error recovery rewrite

The first of the following two patches contains the removal of some unneeded, inactive and unused code, some trivial corrections to comments and a printk, and the return of a proper status in qla1280_queuecommand. No fundamental logic changes are made.

The second of the two patches reworks driver error recovery. The driver now waits for the scsi commands associated with a particular error recovery step to be returned to the mid-layer, and returns the appropriate SUCCESS or FAILED status. Removes unneeded polling of chip for interrupts.

This patch also bumps the driver version number.

These patches apply to linux-2.6.30-rc1.

Acked-by on the v1 series
#1 lore raw
Quoted 12 lines · Michael Reed

The first of the following two patches contains the removal of some unneeded, inactive and unused code, some trivial corrections to comments and a printk, and the return of a proper status in qla1280_queuecommand. No fundamental logic changes are made.

The second of the two patches reworks driver error recovery. The driver now waits for the scsi commands associated with a particular error recovery step to be returned to the mid-layer, and returns the appropriate SUCCESS or FAILED status. Removes unneeded polling of chip for interrupts.

Quoted 5 lines

This patch also bumps the driver version number.

These patches apply to linux-2.6.30-rc1.

Hi Mike,

Great work!

Cheers,
Jes