2.6.30-rc1 (latest git): thinkpad-acpi: cannot control brightness with hotkeys

Hi there,

With latest git kernel, I'm no longer able to control my Thinkpad (W500) brightness, although I can still control the backlight, bluetooth etc.

I originally got some errors (below), but I was able to get around them by changing /etc/modprobe.d/thinkpad_acpi
from the (default OPENSUSE)
options thinkpad_acpi experimental=1 hotkey=enable,0xffffff to
options thinkpad_acpi experimental=1

Any ideas on how I can regain control over the brightness gas-pedal?

Niel

dmesg:
thinkpad_acpi: ThinkPad ACPI Extras v0.22
thinkpad_acpi: http://ibm-acpi.sf.net/
thinkpad_acpi: ThinkPad BIOS 6FET50WW (1.20 ), EC 7VHT12WW-1.01
thinkpad_acpi: Lenovo ThinkPad W500, model 40622XG
thinkpad_acpi: radio switch found; radios are enabled
thinkpad_acpi: This ThinkPad has standard ACPI backlight brightness control, supported by the ACPI video driver
thinkpad_acpi: Disabling thinkpad-acpi brightness events by default...
thinkpad_acpi: procfs hotkey enable/disable: access by process with PID 890

WARNING: at drivers/platform/x86/thinkpad_acpi.c:2954
hotkey_enabledisable_warn+0x3e/0x43 [thinkpad_acpi]()
thinkpad_acpi: hotkey enable/disable functionality has been removed from
the driver. Hotkeys are always enabled.
Modules linked in: thinkpad_acpi(+) snd_hda_intel(+) rfkill

snd_hda_codec rtc_cmos snd_hwdep mac80211 video i2c_i801 rtc_core snd_pcm ohci1394 led_class battery ac output snd_timer snd soundcore snd_page_alloc e1000e intel_agp button joydev wmi i2c_core sr_mod rtc_lib cfg80211 sg ieee1394 iTCO_wdt agpgart cdrom nvram iTCO_vendor_support sd_mod ehci_hcd uhci_hcd usbcore ext4 jbd2 crc16 edd ext3 mbcache jbd fan ahci libata scsi_mod thermal processor

 [<f81a3f7c>] hotkey_enabledisable_warn+0x3e/0x43 [thinkpad_acpi]
 [<f81a5234>] hotkey_write+0x68/0x162 [thinkpad_acpi]
 [<f7c63f62>] thinkpad_acpi_module_init+0x742/0x839 [thinkpad_acpi]
 [<f7c63820>] ? thinkpad_acpi_module_init+0x0/0x839 [thinkpad_acpi]

Registered led device: tpacpi::thinklight
thinkpad_acpi: Standard ACPI backlight interface available, not loading native one.

Hi there,

With latest git kernel, I'm no longer able to control my Thinkpad (W500) brightness, although I can still control the backlight, bluetooth etc.

Niel

Quoted 4 lines · Niel Lambrechts

Hi there,

With latest git kernel, I'm no longer able to control my Thinkpad (W500) brightness, although I can still control the backlight, bluetooth etc.

Same problem here (but no warning) on T400. I wasn't able to get it working. Tried using different values (0, 1,2, 3) for brightness_mode without success.

(cc's added)

On Sat, 11 Apr 2009 23:07:16 +0200 Niel Lambrechts <[email protected]> wrote:

Quoted 5 lines

Hi there,

With latest git kernel, I'm no longer able to control my Thinkpad (W500) brightness, although I can still control the backlight, bluetooth etc.

So 2.6.29 was OK

(cc's added)

On Sat, 11 Apr 2009 23:07:16 +0200 Niel Lambrechts <[email protected]> wrote:

Quoted 5 lines

Hi there,

With latest git kernel, I'm no longer able to control my Thinkpad (W500) brightness, although I can still control the backlight, bluetooth etc.

So 2.6.29 was OK?

Quoted 41 lines

I originally got some errors (below), but I was able to get around them by changing /etc/modprobe.d/thinkpad_acpi
from the (default OPENSUSE)
options thinkpad_acpi experimental=1 hotkey=enable,0xffffff to
options thinkpad_acpi experimental=1

Any ideas on how I can regain control over the brightness gas-pedal?

Niel

dmesg:
thinkpad_acpi: ThinkPad ACPI Extras v0.22
thinkpad_acpi: http://ibm-acpi.sf.net/
thinkpad_acpi: ThinkPad BIOS 6FET50WW (1.20 ), EC 7VHT12WW-1.01
thinkpad_acpi: Lenovo ThinkPad W500, model 40622XG
thinkpad_acpi: radio switch found; radios are enabled
thinkpad_acpi: This ThinkPad has standard ACPI backlight brightness control, supported by the ACPI video driver
thinkpad_acpi: Disabling thinkpad-acpi brightness events by default...
thinkpad_acpi: procfs hotkey enable/disable: access by process with PID 890

WARNING: at drivers/platform/x86/thinkpad_acpi.c:2954
hotkey_enabledisable_warn+0x3e/0x43 [thinkpad_acpi]()
thinkpad_acpi: hotkey enable/disable functionality has been removed from
the driver. Hotkeys are always enabled.
Modules linked in: thinkpad_acpi(+) snd_hda_intel(+) rfkill

snd_hda_codec rtc_cmos snd_hwdep mac80211 video i2c_i801 rtc_core snd_pcm ohci1394 led_class battery ac output snd_timer snd soundcore snd_page_alloc e1000e intel_agp button joydev wmi i2c_core sr_mod rtc_lib cfg80211 sg ieee1394 iTCO_wdt agpgart cdrom nvram iTCO_vendor_support sd_mod ehci_hcd uhci_hcd usbcore ext4 jbd2 crc16 edd ext3 mbcache jbd fan ahci libata scsi_mod thermal processor

 [<f81a3f7c>] hotkey_enabledisable_warn+0x3e/0x43 [thinkpad_acpi]
 [<f81a5234>] hotkey_write+0x68/0x162 [thinkpad_acpi]
 [<f7c63f62>] thinkpad_acpi_module_init+0x742/0x839 [thinkpad_acpi]
 [<f7c63820>] ? thinkpad_acpi_module_init+0x0/0x839 [thinkpad_acpi]

Registered led device: tpacpi::thinklight
thinkpad_acpi: Standard ACPI backlight interface available, not loading native one.

Could it be related to this commit?

commit 0e501834f8c2ba7de2a56e332d346dcf4ac0b593

Author: Henrique de Moraes Holschuh <[email protected]>
Date:   Sat Apr 4 04:25:53 2009 +0000

thinkpad-acpi: rework brightness support

Refactor and redesign the brightness control backend...

Quoted 1 line

options thinkpad_acpi experimental=1 hotkey=enable,0xffffff

Quoted 1 line

Any ideas on how I can regain control over the brightness gas-pedal?

Quoted 4 lines

WARNING: at drivers/platform/x86/thinkpad_acpi.c:2954
hotkey_enabledisable_warn+0x3e/0x43 [thinkpad_acpi]()

thinkpad_acpi: hotkey enable/disable functionality has been removed from the driver. Hotkeys are always enabled.

Quoted 2 lines

thinkpad_acpi: Standard ACPI backlight interface available, not loading native one.

Okay, please bear with me (I'm a git novice) but when I did

'git revert 0e501834f8c2ba7de2a56e332d346dcf4ac0b593'

and recompiled I was still unable to control the brightness with the hotkeys...

Quoted 2 lines

With latest git kernel, I'm no longer able to control my Thinkpad (W500) brightness, although I can still control the backlight, bluetooth etc.

Quoted 3 lines · Andrew Morton

Quoted 3 lines

With latest git kernel, I'm no longer able to control my Thinkpad (W500) brightness, although I can still control the backlight, bluetooth etc.

Niels, something just occourred to me. Is your problem the hotkeys, or the brightness control itself? Check /sys/class/backlight/*, please. What do you have in there? Does it work?

If it is the hotkeys, make sure you either have the legacy ACPI events enabled in kconfig, or that you have something tied to the thinkpad-acpi input device (no, HAL doesn't do it _yet_, it just forwards the events to X.org)...

[ 1910.228636] ACPI Error (video-0537): Current brightness invalid [20090320]
[ 1910.229006] input: Video Bus as /devices/LNXSYSTM:00/device:00/PNP0A08:00/device:34/device:35/input/input9
[ 1910.390188] ACPI: Video Device [VGA] (multi-head: yes  rom: no  post: no)

Quoted 6 lines · Henrique de Moraes Holschuh

Quoted 3 lines · Andrew Morton

Quoted 3 lines

With latest git kernel, I'm no longer able to control my Thinkpad (W500) brightness, although I can still control the backlight, bluetooth etc.

Quoted 4 lines

Niels, something just occourred to me. Is your problem the hotkeys, or the brightness control itself? Check /sys/class/backlight/*, please. What do you have in there? Does it work?

Hi Henrique,

The directory is empty - this is when I used 2.6.30-rc1 (latest git) from yesterday. I'll keep retrying with the latest git kernels though.

The only additional observations I can provide is:
1) pulling/plugging the power cord does actually have an effect on the brightness.
2) resuming form hibernate - Xorg is blank, until I simultaneously press a keyboard key and touch the synaptics pad. But I have this problem in 2.6.28/2.6.29 as well, and I guess it could either be vesafb or ACPI related, as it also happened when I used s2disk in a console session outside of X.

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

which contains:
drwxr-xr-x 3 root root 0 Apr 12 20:01 ./
drwxr-xr-x 3 root root 0 Apr 12 20:01 ../

(quoted diff) +0 -4

-r--r--r-- 1 root root 4096 Apr 12 20:02 actual_brightness
-rw-r--r-- 1 root root 4096 Apr 12 20:02 bl_power
-rw-r--r-- 1 root root 4096 Apr 12 20:02 brightness
-r--r--r-- 1 root root 4096 Apr 12 20:01 max_brightness

drwxr-xr-x 2 root root 0 Apr 12 20:02 power/
lrwxrwxrwx 1 root root 0 Apr 12 20:01 subsystem ->
../../../../class/backlight/
-rw-r--r-- 1 root root 4096 Apr 12 20:01 uevent

max_brightness = 15 and echoing values [0-15] to brightness controls it as expected, or just using the standard thinkpad keys (Fn-Home to increase).

Quoted 5 lines

If it is the hotkeys, make sure you either have the legacy ACPI events enabled in kconfig, or that you have something tied to the thinkpad-acpi input device (no, HAL doesn't do it _yet_, it just forwards the events to X.org)...

I'm not sure what provides the "glue", other than "it works" in 2.6.29.1 and 2.6.28.9 with OpenSUSE 11.1 with xorg-x11-server-7.4-41.8.

Would it help if I send the ACPI parts of my .config? These are based on the default /proc/config.gz that comes with the distro.

# Power management and ACPI
options
CONFIG_ACPI=y

CONFIG_ACPI_SLEEP=y

CONFIG_ACPI_PROCFS=y

CONFIG_ACPI_PROCFS_POWER=y

CONFIG_ACPI_SYSFS_POWER=y

CONFIG_ACPI_PROC_EVENT=y

CONFIG_ACPI_AC=m

CONFIG_ACPI_BATTERY=m

CONFIG_ACPI_BUTTON=m

CONFIG_ACPI_VIDEO=m

CONFIG_ACPI_FAN=m

CONFIG_ACPI_DOCK=y
CONFIG_ACPI_PROCESSOR=m
CONFIG_ACPI_HOTPLUG_CPU=y
CONFIG_ACPI_THERMAL=m
CONFIG_ACPI_CUSTOM_DSDT_FILE=""
# CONFIG_ACPI_CUSTOM_DSDT is not set
CONFIG_ACPI_BLACKLIST_YEAR=2001
# CONFIG_ACPI_DEBUG is not set
# CONFIG_ACPI_PCI_SLOT is not set
CONFIG_ACPI_CONTAINER=m
CONFIG_ACPI_SBS=m
CONFIG_X86_ACPI_CPUFREQ=m
CONFIG_X86_POWERNOW_K7_ACPI=y
CONFIG_X86_POWERNOW_K8_ACPI=y
CONFIG_HOTPLUG_PCI_ACPI=m
CONFIG_HOTPLUG_PCI_ACPI_IBM=m
CONFIG_PNPACPI=y
CONFIG_BLK_DEV_IDEACPI=y
CONFIG_ATA_ACPI=y
CONFIG_PATA_ACPI=m
CONFIG_THINKPAD_ACPI=m
# CONFIG_THINKPAD_ACPI_DEBUGFACILITIES is not set
# CONFIG_THINKPAD_ACPI_DEBUG is not set
CONFIG_THINKPAD_ACPI_BAY=y
CONFIG_THINKPAD_ACPI_VIDEO=y
CONFIG_THINKPAD_ACPI_HOTKEY_POLL=y
CONFIG_ACPI_WMI=m
# CONFIG_ACPI_ASUS is not set
CONFIG_ACPI_TOSHIBA=m

Regards,
Niel
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 10 lines · Henrique de Moraes Holschuh

Quoted 3 lines · Andrew Morton

Quoted 3 lines

With latest git kernel, I'm no longer able to control my Thinkpad (W500) brightness, although I can still control the backlight, bluetooth etc.

Niels, something just occourred to me. Is your problem the hotkeys, or the brightness control itself? Check /sys/class/backlight/*, please. What do you have in there? Does it work?

Hi Henrique,

The directory is empty - this is when I used 2.6.30-rc1 (latest git) from yesterday. I'll keep retrying with the latest git kernels though.

The only additional observations I can provide is:
1) pulling/plugging the power cord does actually have an effect on the brightness.
2) resuming form hibernate - Xorg is blank, until I simultaneously press a keyboard key and touch the synaptics pad. But I have this problem in 2.6.28/2.6.29 as well, and I guess it could either be vesafb or ACPI related, as it also happened when I used s2disk in a console session outside of X.

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

which contains:
drwxr-xr-x 3 root root 0 Apr 12 20:01 ./
drwxr-xr-x 3 root root 0 Apr 12 20:01 ../

(quoted diff) +0 -4

-r--r--r-- 1 root root 4096 Apr 12 20:02 actual_brightness
-rw-r--r-- 1 root root 4096 Apr 12 20:02 bl_power
-rw-r--r-- 1 root root 4096 Apr 12 20:02 brightness
-r--r--r-- 1 root root 4096 Apr 12 20:01 max_brightness

drwxr-xr-x 2 root root 0 Apr 12 20:02 power/
lrwxrwxrwx 1 root root 0 Apr 12 20:01 subsystem ->
../../../../class/backlight/
-rw-r--r-- 1 root root 4096 Apr 12 20:01 uevent

max_brightness = 15 and echoing values [0-15] to brightness controls it as expected, or just using the standard thinkpad keys (Fn-Home to increase).

Quoted 5 lines

If it is the hotkeys, make sure you either have the legacy ACPI events enabled in kconfig, or that you have something tied to the thinkpad-acpi input device (no, HAL doesn't do it _yet_, it just forwards the events to X.org)...

I'm not sure what provides the "glue", other than "it works" in 2.6.29.1 and 2.6.28.9 with OpenSUSE 11.1 with xorg-x11-server-7.4-41.8.

Would it help if I send the ACPI parts of my .config? These are based on the default /proc/config.gz that comes with the distro.

# Power management and ACPI
options
CONFIG_ACPI=y

CONFIG_ACPI_SLEEP=y

CONFIG_ACPI_PROCFS=y

CONFIG_ACPI_PROCFS_POWER=y

CONFIG_ACPI_SYSFS_POWER=y

CONFIG_ACPI_PROC_EVENT=y

CONFIG_ACPI_AC=m

CONFIG_ACPI_BATTERY=m

CONFIG_ACPI_BUTTON=m

CONFIG_ACPI_VIDEO=m

CONFIG_ACPI_FAN=m

CONFIG_ACPI_DOCK=y
CONFIG_ACPI_PROCESSOR=m
CONFIG_ACPI_HOTPLUG_CPU=y
CONFIG_ACPI_THERMAL=m
CONFIG_ACPI_CUSTOM_DSDT_FILE=""
# CONFIG_ACPI_CUSTOM_DSDT is not set
CONFIG_ACPI_BLACKLIST_YEAR=2001
# CONFIG_ACPI_DEBUG is not set
# CONFIG_ACPI_PCI_SLOT is not set
CONFIG_ACPI_CONTAINER=m
CONFIG_ACPI_SBS=m
CONFIG_X86_ACPI_CPUFREQ=m
CONFIG_X86_POWERNOW_K7_ACPI=y
CONFIG_X86_POWERNOW_K8_ACPI=y
CONFIG_HOTPLUG_PCI_ACPI=m
CONFIG_HOTPLUG_PCI_ACPI_IBM=m
CONFIG_PNPACPI=y
CONFIG_BLK_DEV_IDEACPI=y
CONFIG_ATA_ACPI=y
CONFIG_PATA_ACPI=m
CONFIG_THINKPAD_ACPI=m
# CONFIG_THINKPAD_ACPI_DEBUGFACILITIES is not set
# CONFIG_THINKPAD_ACPI_DEBUG is not set
CONFIG_THINKPAD_ACPI_BAY=y
CONFIG_THINKPAD_ACPI_VIDEO=y
CONFIG_THINKPAD_ACPI_HOTKEY_POLL=y
CONFIG_ACPI_WMI=m
# CONFIG_ACPI_ASUS is not set
CONFIG_ACPI_TOSHIBA=m

Regards,
Niel
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 9 lines · Niel Lambrechts

Quoted 7 lines · Henrique de Moraes Holschuh

Quoted 4 lines · Andrew Morton

Quoted 4 lines

With latest git kernel, I'm no longer able to control my Thinkpad (W500) brightness, although I can still control the backlight, bluetooth etc.

Quoted 7 lines

Quoted 5 lines

Niels, something just occourred to me. Is your problem the hotkeys, or the brightness control itself? Check /sys/class/backlight/*, please. What do you have in there? Does it work?

Hi Henrique,

Will you please check whether there exists the /sys/class/backlight/*/*?

If not, will you please load the i915 driver and see whether the backlight can be controlled by hotkeys?(The CONFIG_DRM_I915_KMS should be enabled in kernel configuration).

Thanks.

Quoted 28 lines

The directory is empty - this is when I used 2.6.30-rc1 (latest git) from yesterday. I'll keep retrying with the latest git kernels though.

The only additional observations I can provide is:
1) pulling/plugging the power cord does actually have an effect on the brightness.
2) resuming form hibernate - Xorg is blank, until I simultaneously press a keyboard key and touch the synaptics pad. But I have this problem in 2.6.28/2.6.29 as well, and I guess it could either be vesafb or ACPI related, as it also happened when I used s2disk in a console session outside of X.

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

which contains:
drwxr-xr-x 3 root root 0 Apr 12 20:01 ./
drwxr-xr-x 3 root root 0 Apr 12 20:01 ../

(quoted diff) +0 -4

-r--r--r-- 1 root root 4096 Apr 12 20:02 actual_brightness
-rw-r--r-- 1 root root 4096 Apr 12 20:02 bl_power
-rw-r--r-- 1 root root 4096 Apr 12 20:02 brightness
-r--r--r-- 1 root root 4096 Apr 12 20:01 max_brightness

drwxr-xr-x 2 root root 0 Apr 12 20:02 power/
lrwxrwxrwx 1 root root 0 Apr 12 20:01 subsystem ->
../../../../class/backlight/
-rw-r--r-- 1 root root 4096 Apr 12 20:01 uevent

Quoted 3 lines

max_brightness = 15 and echoing values [0-15] to brightness controls it as expected, or just using the standard thinkpad keys (Fn-Home to increase).

please attach the acpidump output.
please apply this patch and see if it helps,
http://patchwork.kernel.org/patch/17339/

Quoted 5 lines · Zhang Rui

please attach the acpidump output.
please apply this patch and see if it helps,
http://patchwork.kernel.org/patch/17339/

Hi,

The patch you mention above has no effect when applied to the latest 2.6.30-rc1 git kernel. I'm still unable to control brightness, and the display is still blank on resume (unless I press both a keyboard key and touch the synaptic pad).

dmesg shows:
thinkpad_acpi: ThinkPad ACPI Extras v0.22
thinkpad_acpi: http://ibm-acpi.sf.net/
thinkpad_acpi: ThinkPad BIOS 6FET50WW (1.20 ), EC 7VHT12WW-1.01
thinkpad_acpi: Lenovo ThinkPad W500, model 40622XG
thinkpad_acpi: radio switch found; radios are enabled
thinkpad_acpi: This ThinkPad has standard ACPI backlight brightness control, supported by the ACPI video driver
thinkpad_acpi: Disabling thinkpad-acpi brightness events by default... Registered led device: tpacpi::thinklight
Registered led device: tpacpi::power
Registered led device: tpacpi::standby
thinkpad_acpi: Standard ACPI backlight interface available, not loading native one.
pci 0000:00:02.0: power state changed by ACPI to D0

but /sys/class/backlight still is empty.

acpidump output attached, please let me know if I can test anything else or provide more info...

Quoted 3 lines

Quoted 3 lines

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

Quoted 30 lines · Niel Lambrechts

Quoted 5 lines · Zhang Rui

please attach the acpidump output.
please apply this patch and see if it helps,
http://patchwork.kernel.org/patch/17339/

Hi,

The patch you mention above has no effect when applied to the latest 2.6.30-rc1 git kernel. I'm still unable to control brightness, and the display is still blank on resume (unless I press both a keyboard key and touch the synaptic pad).

dmesg shows:
thinkpad_acpi: ThinkPad ACPI Extras v0.22
thinkpad_acpi: http://ibm-acpi.sf.net/
thinkpad_acpi: ThinkPad BIOS 6FET50WW (1.20 ), EC 7VHT12WW-1.01
thinkpad_acpi: Lenovo ThinkPad W500, model 40622XG
thinkpad_acpi: radio switch found; radios are enabled
thinkpad_acpi: This ThinkPad has standard ACPI backlight brightness control, supported by the ACPI video driver
thinkpad_acpi: Disabling thinkpad-acpi brightness events by default... Registered led device: tpacpi::thinklight
Registered led device: tpacpi::power
Registered led device: tpacpi::standby
thinkpad_acpi: Standard ACPI backlight interface available, not loading native one.
pci 0000:00:02.0: power state changed by ACPI to D0

Quoted 5 lines

but /sys/class/backlight still is empty.

acpidump output attached, please let me know if I can test anything else or provide more info...

I've just retried this with the latest Lenovo firmware *2.12-1.01 *6FET64WW (which came out last week). It still gives the same bad result though...

I attach acpidump again in case it matters after upgrading the BIOS.

cheers
Niel

Niel,

please make sure CONFIG_ACPI_VIDEO is set,
please attach the full dmesg output.

thanks,
rui

Quoted 45 lines · Niel Lambrechts

Quoted 30 lines · Niel Lambrechts

Quoted 5 lines · Zhang Rui

please attach the acpidump output.
please apply this patch and see if it helps,
http://patchwork.kernel.org/patch/17339/

Hi,

The patch you mention above has no effect when applied to the latest 2.6.30-rc1 git kernel. I'm still unable to control brightness, and the display is still blank on resume (unless I press both a keyboard key and touch the synaptic pad).

dmesg shows:
thinkpad_acpi: ThinkPad ACPI Extras v0.22
thinkpad_acpi: http://ibm-acpi.sf.net/
thinkpad_acpi: ThinkPad BIOS 6FET50WW (1.20 ), EC 7VHT12WW-1.01
thinkpad_acpi: Lenovo ThinkPad W500, model 40622XG
thinkpad_acpi: radio switch found; radios are enabled
thinkpad_acpi: This ThinkPad has standard ACPI backlight brightness control, supported by the ACPI video driver
thinkpad_acpi: Disabling thinkpad-acpi brightness events by default... Registered led device: tpacpi::thinklight
Registered led device: tpacpi::power
Registered led device: tpacpi::standby
thinkpad_acpi: Standard ACPI backlight interface available, not loading native one.
pci 0000:00:02.0: power state changed by ACPI to D0

Quoted 5 lines

but /sys/class/backlight still is empty.

acpidump output attached, please let me know if I can test anything else or provide more info...

I've just retried this with the latest Lenovo firmware *2.12-1.01 *6FET64WW (which came out last week). It still gives the same bad result though...

I attach acpidump again in case it matters after upgrading the BIOS.

cheers
Niel

Quoted 4 lines · Niel Lambrechts

Quoted 4 lines

Quoted 4 lines

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

Well, that at least confirms that thinkpad-acpi doesn't have anything to do with your troubles, you were using acpi video.

Quoted 10 lines · Henrique de Moraes Holschuh

Quoted 4 lines · Niel Lambrechts

Quoted 4 lines

Quoted 4 lines

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

Well, that at least confirms that thinkpad-acpi doesn't have anything to do with your troubles, you were using acpi video.

Okay, I've bisected it to:

74a365b3f354fafc537efa5867deb7a9fadbfe27 is first bad commit commit 74a365b3f354fafc537efa5867deb7a9fadbfe27

Author: Matthew Garrett <[email protected]>
Date:   Thu Mar 19 21:35:39 2009 +0000

ACPI: Populate DIDL before registering ACPI video device on Intel

---

Matthew, can you help?

Regards,
Niel

Quoted 10 lines · Henrique de Moraes Holschuh

Quoted 4 lines · Niel Lambrechts

Quoted 4 lines

Quoted 4 lines

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

Well, that at least confirms that thinkpad-acpi doesn't have anything to do with your troubles, you were using acpi video.

Okay, I've bisected it to:

74a365b3f354fafc537efa5867deb7a9fadbfe27 is first bad commit commit 74a365b3f354fafc537efa5867deb7a9fadbfe27

Author: Matthew Garrett <[email protected]>
Date:   Thu Mar 19 21:35:39 2009 +0000

ACPI: Populate DIDL before registering ACPI video device on Intel

Quoted 19 lines · Niel Lambrechts

Quoted 10 lines · Henrique de Moraes Holschuh

Quoted 4 lines · Niel Lambrechts

Quoted 4 lines

Quoted 4 lines

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

Well, that at least confirms that thinkpad-acpi doesn't have anything to do with your troubles, you were using acpi video.

Okay, I've bisected it to:

74a365b3f354fafc537efa5867deb7a9fadbfe27 is first bad commit commit 74a365b3f354fafc537efa5867deb7a9fadbfe27

Author: Matthew Garrett <[email protected]>
Date:   Thu Mar 19 21:35:39 2009 +0000

Quoted 2 lines

ACPI: Populate DIDL before registering ACPI video device on Intel

please set CONFIG_DRM_I915_KMS, reload the ACPI video driver after loading i915 and see if it helps.

thanks,
rui

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 21 lines · Niel Lambrechts

Quoted 12 lines · Henrique de Moraes Holschuh

Quoted 5 lines · Niel Lambrechts

Quoted 5 lines

Quoted 5 lines

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

Well, that at least confirms that thinkpad-acpi doesn't have anything to do with your troubles, you were using acpi video.

Okay, I've bisected it to:

74a365b3f354fafc537efa5867deb7a9fadbfe27 is first bad commit commit 74a365b3f354fafc537efa5867deb7a9fadbfe27

Author: Matthew Garrett <[email protected]>
Date:   Thu Mar 19 21:35:39 2009 +0000

Quoted 9 lines

ACPI: Populate DIDL before registering ACPI video device on Intel

---

Matthew, can you help?

Regards,
Niel

Just to note,

I have nvidia, and yet have the same bug.
I reverted this commit - didn't help.

I get lots of
ACPI: Failed to switch the brightnes
when I press hardware keys that change brightness
(even these sometimes don't work)

Quoted 21 lines · Niel Lambrechts

Quoted 12 lines · Henrique de Moraes Holschuh

Quoted 5 lines · Niel Lambrechts

Quoted 5 lines

Quoted 5 lines

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

Well, that at least confirms that thinkpad-acpi doesn't have anything to do with your troubles, you were using acpi video.

Okay, I've bisected it to:

74a365b3f354fafc537efa5867deb7a9fadbfe27 is first bad commit commit 74a365b3f354fafc537efa5867deb7a9fadbfe27

Author: Matthew Garrett <[email protected]>
Date:   Thu Mar 19 21:35:39 2009 +0000

Quoted 3 lines

ACPI: Populate DIDL before registering ACPI video device on Intel

please set CONFIG_DRM_I915_KMS, reload the ACPI video driver after loading i915 and see if it helps.

Quoted 27 lines · Zhang Rui

Quoted 24 lines · Niel Lambrechts

Quoted 12 lines · Henrique de Moraes Holschuh

Quoted 5 lines · Niel Lambrechts

Quoted 5 lines

Quoted 5 lines

In 2.6.29.1:
lrwxrwxrwx 1 root root 0 Apr 12 20:01 /sys/class/backlight/acpi_video0 -> ../../devices/virtual/backlight/acpi_video0

Well, that at least confirms that thinkpad-acpi doesn't have anything to do with your troubles, you were using acpi video.

Okay, I've bisected it to:

74a365b3f354fafc537efa5867deb7a9fadbfe27 is first bad commit commit 74a365b3f354fafc537efa5867deb7a9fadbfe27

Author: Matthew Garrett <[email protected]>
Date:   Thu Mar 19 21:35:39 2009 +0000

ACPI: Populate DIDL before registering ACPI video device on Intel

Quoted 3 lines

please set CONFIG_DRM_I915_KMS, reload the ACPI video driver after loading i915 and see if it helps.

In all the kernels I've tried (up to 2.6.30-rc2), I get issues with KMS:

I boot with 'modeset=1 i915=1', console login is okay and 'modprobe i915 modeset=1' seems to work - the console resolution changes (very small 1920x1200).

The behaviour seems slightly different from before your 74a365b3f354 commit in that /sys/class/backlight remains empty until i915 gets loaded for the first time, the contents then persist even if i915 is unloaded. Perhaps the directory was populated by a different kernel module, since when I did the bisect yesterday the directory would be there on boot before I started X or loaded i915.

I'm not sure if that matters to any other user-space app. (or if
ideally one is supposed to be able to control brightness in the console without having to load i915), but it's fine for controlling brightness in Xorg.

Quoted 7 lines · Niel Lambrechts

The behaviour seems slightly different from before your 74a365b3f354 commit in that /sys/class/backlight remains empty until i915 gets loaded for the first time, the contents then persist even if i915 is unloaded. Perhaps the directory was populated by a different kernel module, since when I did the bisect yesterday the directory would be there on boot before I started X or loaded i915.

In the past the directory would be created when the acpi video driver was loaded, but probably wouldn't work. Doing it that way is a violation of the opregion spec and causes some machines to break in a horrible manner, so I'd prefer not to go back to that version...

If you use modesetting then you shouldn't need to launch X to get working brightness control. The problem with the old-style world is that you won't get interrupts until X comes up.

So is there any chance of getting this fix merged any time soon (at least before 2.6.30 is out)?

I'd love to use KMS, but I have no idea how to troubleshoot the freeze I'm getting after the main gdm login screen. Or is there still a future i915 milestone(s) to be reached before I can realistically do i915.modeset=1, given the large amount of activity around this in recent times?

Does this help?

http://marc.info/?l=linux-acpi&m=123967828429865&w=2
check whether the ACPI video driver is deferrable only when KMS is

drivers/gpu/drm/i915/i915_opregion.c +5 -4

index 6942772..8dc1fd3 100644
@@ -370,11 +370,8 @@ int intel_opregion_init(struct drm_device *dev, int resume)
 	if (mboxes & MBOX_ACPI) {
 		DRM_DEBUG("Public ACPI methods supported\n");
 		opregion->acpi = base + OPREGION_ACPI_OFFSET;
-		if (drm_core_check_feature(dev, DRIVER_MODESET)) {
+		if (drm_core_check_feature(dev, DRIVER_MODESET))
 			intel_didl_outputs(dev);
-			if (!resume)
-				acpi_video_register();
-		}
 	} else {
 		DRM_DEBUG("Public ACPI methods not supported\n");
 		err = -ENOTSUPP;

@@ -391,6 +388,10 @@ int intel_opregion_init(struct drm_device *dev, int resume)
 		opregion->asle = base + OPREGION_ASLE_OFFSET;
 	}
 
+	if (!resume)
+		acpi_video_register();
+
+
 	/* Notify BIOS we are ready to handle ACPI video ext notifs.
 	 * Right now, all the events are handled by the ACPI video module.
 	 * We don't actually need to do anything with them. */