Skip to contentSkip to conversation

osd_uld: fix printk format warning

PATCH In review Randy Dunlap 2 participants 2 messages Apr 23, 2009 – Apr 26, 2009 SCSI

lore
Share & tools
lore

Randy Dunlap

author
#0 lore raw

PATCH 1/1 osd_uld: fix printk format warning

From: Randy Dunlap <[email protected]>

Fix printk format warnings in osd_uld:

drivers/scsi/osd/osd_uld.c:191: warning:format '%s' expects type 'char *', but argument 2 has type 'struct path'

Also fix a small typo.

Signed-off-by Randy Dunlap <[email protected]>
---
 drivers/scsi/osd/osd_uld.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/osd/osd_uld.c +1 -1
@@ -188,7 +188,7 @@ struct osd_dev *osduld_path_lookup(const
 
 	error = kern_path(name, LOOKUP_FOLLOW, &path);
 	if (error) {
-		OSD_ERR("path_lookup of %s faild=>%d\n", path, error);
+		OSD_ERR("path_lookup of %s failed=>%d\n", name, error);
 		return ERR_PTR(error);
 	}
Signature · 1 line
~Randy
#1 lore raw
Quoted 17 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix printk format warnings in osd_uld:

drivers/scsi/osd/osd_uld.c:191: warning:format '%s' expects type 'char *', but argument 2 has type 'struct path'

Also fix a small typo.

Signed-off-by Randy Dunlap <[email protected]>
---
 drivers/scsi/osd/osd_uld.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/scsi/osd/osd_uld.c struct osd_dev *osduld_path_lookup(const · line 194

Quoted 8 lines
drivers/scsi/osd/osd_uld.c +1 -1
@@ -188,7 +188,7 @@ struct osd_dev *osduld_path_lookup(const
 
 	error = kern_path(name, LOOKUP_FOLLOW, &path);
 	if (error) {
-		OSD_ERR("path_lookup of %s faild=>%d\n", path, error);
+		OSD_ERR("path_lookup of %s failed=>%d\n", name, error);
 		return ERR_PTR(error);
 	}

Hi Randy thanks for the catch.

I cannot do anything with this patch as it is a fallout of an Al Viro's patch which I do not have access to, from any of my trees.

This is:
Reduce path_lookup() abuses

use kern_path() where possible

Signed-off-by Al Viro <[email protected]>

(Linux-next's fe48fce1a72439d1b70dc8a9bce80c46ac4a6c96)

Al hi

Thanks for the fix and simplification. At the time of writing this I did not find the kern_path(), which is much better in this code, Sorry.

Please squash or apply above Randy's patch. And tell me where I can find it so I can test it and send an ACK-BY if that's needed. (Or if you want that I pick this code, I'm here to help)

Thanks a lot for fixing this code
Boaz