Skip to contentSkip to conversation

oops on 2.6.30-rc3-mm1

DISCUSSION jan sonnek 3 participants 3 messages Apr 26, 2009 – Apr 29, 2009

Subsystems (2)
lore
Share & tools
lore

jan sonnek

author
#0 lore raw

I get this oops, when I try to start my X windows (startx)
I have some bug later, but when I switch off some new modules, I was able to start X windows.

Later:
------------

http://bugzilla.kernel.org/show_bug.cgi?id=12619

Now:
------------

BUG: unable to handle kernel NULL pointer dereference at 00000040
IP: [<c015409c>] balance_dirty_pages_ratelimited_nr+0x10/0x29b
*pde = 36b28067 *pte = 00000000
Oops: 0000 [#1] PREEMPT SMP
last sysfs file: /sys/devices/virtual/dmi/id/chassis_asset_tag
Modules linked in: sco bnep l2cap bluetooth coretemp hwmon ipv6 fuse iwl3945 iwlcore sdhci_pci sr_mod sg sdhci ohci1394 ieee1394 cdrom mmc_core battery mac80211 led_class ricoh_mmc cfg80211 usb_storage [last unloaded: scsi_wait_scan]

Pid: 2867, comm: X Not tainted (2.6.30-rc3-mm1-hanny #27) F3F
EIP: 0060:[<c015409c>] EFLAGS: 00213296 CPU: 0
EIP is at balance_dirty_pages_ratelimited_nr+0x10/0x29b
EAX: 00000000 EBX: 00000008 ECX: 00000000 EDX: 00000001
ESI: 00000000 EDI: 5f372067 EBP: f69a1eec ESP: f69a1e84
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process X (pid: 2867, ti=f69a1000 task=f7164380 task.ti=f69a1000)

Stack:
 f69a1e8c c03691fe f69a1eac 00203292 000000d0 00203292 f7001324 f6ad4474
 000f877d 000f877e f69a1ebc c023ea66 f6b003e0 f6b003e0 f69a1ec4 c03691fe
 f69a1ed8 c017e704 c1be6e40 f6ad43a8 f6823600 00000000 c049f9c0 c1be6e40
Call Trace:
 [<c03691fe>] ? _spin_unlock+0x19/0x24
 [<c023ea66>] ? drm_vm_open_locked+0x5b/0x94
 [<c03691fe>] ? _spin_unlock+0x19/0x24
 [<c017e704>] ? mnt_drop_write+0x6d/0xe6
 [<c015d26c>] ? __do_fault+0x283/0x2bd
 [<c015e784>] ? handle_mm_fault+0x1f7/0x454
 [<c0115472>] ? do_page_fault+0x1e0/0x1ef
 [<c0115292>] ? do_page_fault+0x0/0x1ef
 [<c03694dd>] ? error_code+0x6d/0x74
 [<c0115292>] ? do_page_fault+0x0/0x1ef
Code: e8 af 7a 00 00 89 f0 25 c0 00 00 00 3d c0 00 00 00 74 a1 8d 65 f4 5b 5e 5f c9 c3 55 89 e5 57 56 89 c6 53 bb 08 00 00 00 83 ec 5c <8b> 40 40 83 78 70 00 89 e0 0f 44 1d d8 73 45 c0 25 00 f0 ff ff
EIP: [<c015409c>] balance_dirty_pages_ratelimited_nr+0x10/0x29b SS:ESP 0068:f69a1e84
CR2: 0000000000000040
---[ end trace 84b1cd49fe3274a1 ]---
#1 lore raw
Quoted 11 lines · jan sonnek
BUG: unable to handle kernel NULL pointer dereference at 00000040
IP: [<c015409c>] balance_dirty_pages_ratelimited_nr+0x10/0x29b
*pde = 36b28067 *pte = 00000000
Oops: 0000 [#1] PREEMPT SMP
last sysfs file: /sys/devices/virtual/dmi/id/chassis_asset_tag
Modules linked in: sco bnep l2cap bluetooth coretemp hwmon ipv6 fuse iwl3945

iwlcore sdhci_pci sr_mod sg sdhci ohci1394 ieee1394 cdrom mmc_core battery mac80211 led_class ricoh_mmc cfg80211 usb_storage [last unloaded:
scsi_wait_scan]

Pid: 2867, comm: X Not tainted (2.6.30-rc3-mm1-hanny #27) F3F

Where has 2.6.30-rc3-mm1 been released?

Quoted 6 lines

EIP: 0060:[<c015409c>] EFLAGS: 00213296 CPU: 0
EIP is at balance_dirty_pages_ratelimited_nr+0x10/0x29b
EAX: 00000000 EBX: 00000008 ECX: 00000000 EDX: 00000001
ESI: 00000000 EDI: 5f372067 EBP: f69a1eec ESP: f69a1e84
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process X (pid: 2867, ti=f69a1000 task=f7164380 task.ti=f69a1000)

Quoted 15 lines
Stack:
 f69a1e8c c03691fe f69a1eac 00203292 000000d0 00203292 f7001324 f6ad4474
 000f877d 000f877e f69a1ebc c023ea66 f6b003e0 f6b003e0 f69a1ec4 c03691fe
 f69a1ed8 c017e704 c1be6e40 f6ad43a8 f6823600 00000000 c049f9c0 c1be6e40
Call Trace:
 [<c03691fe>] ? _spin_unlock+0x19/0x24
 [<c023ea66>] ? drm_vm_open_locked+0x5b/0x94
 [<c03691fe>] ? _spin_unlock+0x19/0x24
 [<c017e704>] ? mnt_drop_write+0x6d/0xe6
 [<c015d26c>] ? __do_fault+0x283/0x2bd
 [<c015e784>] ? handle_mm_fault+0x1f7/0x454
 [<c0115472>] ? do_page_fault+0x1e0/0x1ef
 [<c0115292>] ? do_page_fault+0x0/0x1ef
 [<c03694dd>] ? error_code+0x6d/0x74
 [<c0115292>] ? do_page_fault+0x0/0x1ef

This looks like the result of mm-close-page_mkwrite-races-try-3.patch.

Nick, we lost the check for a non-NULL mapping when calling balance_dirty_pages_ratelimited(mapping) in set_page_dirty_balance() when it was replaced in __do_fault().

Since we're operating on page->mapping and not dirty_page->mapping here, perhaps this is necessary (against mmotm, not 2.6.30-rc3-mm1)?
---

mm/memory.c +1 -1
@@ -2905,7 +2905,7 @@ out:
 			page_mkwrite = 1;
 		unlock_page(dirty_page);
 		put_page(dirty_page);
-		if (page_mkwrite)
+		if (page_mkwrite && mapping)
 			balance_dirty_pages_ratelimited(mapping);
 	} else {
 		unlock_page(vmf.page);
maintainer
#2 lore raw
Quoted 12 lines · On Sun, 26 Apr 2009 13:11:25 -0700 (PDT) David Rientjes <[email protected]>…
Quoted 10 lines · jan sonnek
BUG: unable to handle kernel NULL pointer dereference at 00000040
IP: [<c015409c>] balance_dirty_pages_ratelimited_nr+0x10/0x29b
*pde = 36b28067 *pte = 00000000
Oops: 0000 [#1] PREEMPT SMP
last sysfs file: /sys/devices/virtual/dmi/id/chassis_asset_tag
Modules linked in: sco bnep l2cap bluetooth coretemp hwmon ipv6 fuse iwl3945

iwlcore sdhci_pci sr_mod sg sdhci ohci1394 ieee1394 cdrom mmc_core battery mac80211 led_class ricoh_mmc cfg80211 usb_storage [last unloaded:
scsi_wait_scan]

Quoted 3 lines
Quoted 1 line

Pid: 2867, comm: X Not tainted (2.6.30-rc3-mm1-hanny #27) F3F

Where has 2.6.30-rc3-mm1 been released?

I don't bother any more. Semi-daily snapshots are at
http://userweb.kernel.org/~akpm/mmotm/

I might cc lkml on the announcement emails, actually. It's only a few-a-week.

Quoted 35 lines
Quoted 6 lines

EIP: 0060:[<c015409c>] EFLAGS: 00213296 CPU: 0
EIP is at balance_dirty_pages_ratelimited_nr+0x10/0x29b
EAX: 00000000 EBX: 00000008 ECX: 00000000 EDX: 00000001
ESI: 00000000 EDI: 5f372067 EBP: f69a1eec ESP: f69a1e84
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process X (pid: 2867, ti=f69a1000 task=f7164380 task.ti=f69a1000)

Quoted 15 lines
Stack:
 f69a1e8c c03691fe f69a1eac 00203292 000000d0 00203292 f7001324 f6ad4474
 000f877d 000f877e f69a1ebc c023ea66 f6b003e0 f6b003e0 f69a1ec4 c03691fe
 f69a1ed8 c017e704 c1be6e40 f6ad43a8 f6823600 00000000 c049f9c0 c1be6e40
Call Trace:
 [<c03691fe>] ? _spin_unlock+0x19/0x24
 [<c023ea66>] ? drm_vm_open_locked+0x5b/0x94
 [<c03691fe>] ? _spin_unlock+0x19/0x24
 [<c017e704>] ? mnt_drop_write+0x6d/0xe6
 [<c015d26c>] ? __do_fault+0x283/0x2bd
 [<c015e784>] ? handle_mm_fault+0x1f7/0x454
 [<c0115472>] ? do_page_fault+0x1e0/0x1ef
 [<c0115292>] ? do_page_fault+0x0/0x1ef
 [<c03694dd>] ? error_code+0x6d/0x74
 [<c0115292>] ? do_page_fault+0x0/0x1ef

This looks like the result of mm-close-page_mkwrite-races-try-3.patch.

Nick, we lost the check for a non-NULL mapping when calling balance_dirty_pages_ratelimited(mapping) in set_page_dirty_balance() when it was replaced in __do_fault().

Since we're operating on page->mapping and not dirty_page->mapping here, perhaps this is necessary (against mmotm, not 2.6.30-rc3-mm1)?
---

mm/memory.c out: · line 2911

Quoted 8 lines
mm/memory.c +1 -1
@@ -2905,7 +2905,7 @@ out:
 			page_mkwrite = 1;
 		unlock_page(dirty_page);
 		put_page(dirty_page);
-		if (page_mkwrite)
+		if (page_mkwrite && mapping)
 			balance_dirty_pages_ratelimited(mapping);
 	} else {
 		unlock_page(vmf.page);

Yup, this is addressed by mm-close-page_mkwrite-races-try-3-fix.patch