PPC4xx without CONFIG_NET_MULTI
Hi Stefan (and anybody else that can answer),
I'm trying to understand why some 4xx boards use CONFIG_NET_MULTI and a few don't. Is there a technical reason why these few can't (limited storage or something else) or are they just older? There are 47 boards in-tree that use CONFIG_PPC4xx_EMAC and the following 18 use the older net API.
---
bwarren at bwarren-bldsrv:~/src/u-boot-net/include/configs$ grep -l PPC4xx_EMAC * | xargs grep -L CONFIG_NET_MULTIAR405.hCPCIISER4.hCRAYL1.hcsb272.hcsb472.hDP405.hERIC.hEXBITGEN.hHUB405.hJSE.hMIP405.hOCRTC.hORSG.hPIP405.hsbc405.hW7OLMC.hW7OLMG.hWUH405.h
---
I'd like to move all over to CONFIG_NET_MULTI, which in itself is trivial since the EMAC driver supports both APIs, but am wary of breaking something.
regards,
Ben
Hi Ben,
Quoted 5 lines · Ben Warren
Hi Stefan (and anybody else that can answer),
I'm trying to understand why some 4xx boards use
CONFIG_NET_MULTIand a few don't. Is there a technical reason why these few can't (limited storage or something else) or are they just older?
Yes, they are just older. Nobody found the time to clear this up till now.
Quoted 30 lines
There are 47 boards
in-tree that useCONFIG_PPC4xx_EMACand the following 18 use the older net API.
---bwarren at bwarren-bldsrv:~/src/u-boot-net/include/configs$ grep -l
PPC4xx_EMAC*| xargs grep -L
CONFIG_NET_MULTI
AR405.hCPCIISER4.hCRAYL1.hcsb272.hcsb472.hDP405.hERIC.hEXBITGEN.hHUB405.hJSE.hMIP405.hOCRTC.hORSG.hPIP405.hsbc405.hW7OLMC.hW7OLMG.hWUH405.h
---
Quoted 1 line
I'd like to move all over to
CONFIG_NET_MULTI,
That would be great. I thought about this as well but didn't find the time yet to do so.
Quoted 3 lines
which in itself is
trivial since the EMAC driver supports both APIs, but am wary of breaking something.
The reason for this (as far as I overlook things) is simply historical. Nobody found the time to clear this up till now. Chances are good that such a transitions doesn't break anything. I can't test though, since I don't have access to any of those boards. I added Matthias to cc, he is maintaining some of those boards. Maybe he could test if you provided a patch for this?
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
Hi Ben, Hi Stefan,
I will prepare a patch for these boards on thursday:
Quoted 6 lines
AR405.hCPCIISER4.hHUB405.hOCRTC.hORSG.hWUH405.h
I have a cleanup patch ready for DP405 by today :-)
Quoted 1 line
DP405.h
Matthias
Quoted 11 lines · Matthias Fuchs
I will prepare a patch for these boards on thursday:
Quoted 6 lines
AR405.hCPCIISER4.hHUB405.hOCRTC.hORSG.hWUH405.hI have a cleanup patch ready for DP405 by today :-)
Quoted 1 line
DP405.h
Thanks. :)
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
Hi Matthias,
Quoted 12 lines · Matthias Fuchs
Hi Ben, Hi Stefan,
I will prepare a patch for these boards on thursday:
Quoted 7 lines
AR405.hCPCIISER4.hHUB405.hOCRTC.hORSG.hWUH405.h
Quoted 8 lines
I have a cleanup patch ready for DP405 by today :-)
Quoted 2 lines
DP405.hMatthias
I appreciate your help here! As you'll see, I've put together some naive patches to take care of all the boards. I expect I'm missing some things that you'll notice.
thanks again,
Ben
Quoted 21 lines
Hi Matthias,
Quoted 18 lines · Matthias Fuchs
Hi Ben, Hi Stefan,
I will prepare a patch for these boards on thursday:
Quoted 7 lines
AR405.hCPCIISER4.hHUB405.hOCRTC.hORSG.hWUH405.hI have a cleanup patch ready for DP405 by today :-)
Quoted 2 lines
DP405.h
Quoted 5 lines
Quoted 2 lines
Matthias
I appreciate your help here! As you'll see, I've put together some naive patches to take care of all the boards. I expect I'm missing some things that you'll notice.
Thanks. Seems to be fine. I expect that Stefan will complain about our patches touching the same boards. Perhaps he will fix it ;-)
Matthias
Quoted 6 lines · Matthias Fuchs
Quoted 3 lines
I appreciate your help here! As you'll see, I've put together some naive patches to take care of all the boards. I expect I'm missing some things that you'll notice.
Thanks. Seems to be fine. I expect that Stefan will complain about our patches touching the same boards. Perhaps he will fix it ;-)
Yep. I just got a merge conflict here. And resolved it.
Ben, I suggest that I push your 4xx/CONFIG_NET_MULTI patches via my ppc4xx/next repo into mainline because of these problems. Is this ok with you?
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
Quoted 6 lines · Stefan Roese
Quoted 2 lines · Matthias Fuchs
Quoted 2 lines
I appreciate your help here! As you'll see, I've put together some naive patches to take care of all the boards. I expect I'm missing
some
Quoted 2 lines
Quoted 1 line
things that you'll notice.
Quoted 9 lines
Quoted 2 lines
Thanks. Seems to be fine. I expect that Stefan will complain about our patches touching the same boards. Perhaps he will fix it ;-)
Yep. I just got a merge conflict here. And resolved it.
Ben, I suggest that I push your 4xx/CONFIG_NET_MULTI patches via my ppc4xx/next repo into mainline because of these problems. Is this ok with you?
Sure. Thanks!
Ben