cgroups: make messages more readable

PATCH In review Randy Dunlap 3 participants 3 messages Apr 28, 2009 – May 4, 2009 1 message not in the archive Memory management

lore

Share & tools

lore

Randy Dunlap

author

2009-04-28 20:53 UTC #0 lore raw

PATCH 1/1 cgroups: make messages more readable

From: Randy Dunlap <[email protected]>

Fix some cgroup messages to read better.
Update MAINTAINERS to include mm/*cgroup* files.

Signed-off-by Randy Dunlap <[email protected]>

---
 MAINTAINERS      |    1 +
 mm/page_cgroup.c |   14 +++++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)

mm/page_cgroup.c +7 -7

@@ -83,12 +83,12 @@ void __init page_cgroup_init(void)
 			goto fail;
 	}
 	printk(KERN_INFO "allocated %ld bytes of page_cgroup\n", total_usage);
-	printk(KERN_INFO "please try cgroup_disable=memory option if you"
-	" don't want\n");
+	printk(KERN_INFO "please try 'cgroup_disable=memory' option if you"
+	" don't want memory cgroups\n");
 	return;
 fail:
-	printk(KERN_CRIT "allocation of page_cgroup was failed.\n");
-	printk(KERN_CRIT "please try cgroup_disable=memory boot option\n");
+	printk(KERN_CRIT "allocation of page_cgroup failed.\n");
+	printk(KERN_CRIT "please try 'cgroup_disable=memory' boot option\n");
 	panic("Out of memory");
 }

@@ -257,14 +257,14 @@ void __init page_cgroup_init(void)
 		fail = init_section_page_cgroup(pfn);
 	}
 	if (fail) {
-		printk(KERN_CRIT "try cgroup_disable=memory boot option\n");
+		printk(KERN_CRIT "try 'cgroup_disable=memory' boot option\n");
 		panic("Out of memory");
 	} else {
 		hotplug_memory_notifier(page_cgroup_callback, 0);
 	}
 	printk(KERN_INFO "allocated %ld bytes of page_cgroup\n", total_usage);
-	printk(KERN_INFO "please try cgroup_disable=memory option if you don't"
-	" want\n");
+	printk(KERN_INFO "please try 'cgroup_disable=memory' option if you don't"
+	" want memory cgroups\n");
 }
 
 void __meminit pgdat_page_cgroup_init(struct pglist_data *pgdat)

MAINTAINERS +1 -0

@@ -1519,6 +1519,7 @@ L:	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
 S:	Maintained
 F:	include/linux/cgroup*
 F:	kernel/cgroup*
+F:	mm/*cgroup*
 
 CORETEMP HARDWARE MONITORING DRIVER
 P:	Rudolf Marek

Li Zefan

2009-05-04 01:27 UTC #1 lore raw

(sorry for the delayed reply)

Quoted 51 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix some cgroup messages to read better.
Update MAINTAINERS to include mm/*cgroup* files.

Signed-off-by Randy Dunlap <[email protected]>

---
 MAINTAINERS      |    1 +
 mm/page_cgroup.c |   14 +++++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)

mm/page_cgroup.c +7 -7

@@ -83,12 +83,12 @@ void __init page_cgroup_init(void)
 			goto fail;
 	}
 	printk(KERN_INFO "allocated %ld bytes of page_cgroup\n", total_usage);
-	printk(KERN_INFO "please try cgroup_disable=memory option if you"
-	" don't want\n");
+	printk(KERN_INFO "please try 'cgroup_disable=memory' option if you"
+	" don't want memory cgroups\n");
 	return;
 fail:
-	printk(KERN_CRIT "allocation of page_cgroup was failed.\n");
-	printk(KERN_CRIT "please try cgroup_disable=memory boot option\n");
+	printk(KERN_CRIT "allocation of page_cgroup failed.\n");
+	printk(KERN_CRIT "please try 'cgroup_disable=memory' boot option\n");
 	panic("Out of memory");
 }

@@ -257,14 +257,14 @@ void __init page_cgroup_init(void)
 		fail = init_section_page_cgroup(pfn);
 	}
 	if (fail) {
-		printk(KERN_CRIT "try cgroup_disable=memory boot option\n");
+		printk(KERN_CRIT "try 'cgroup_disable=memory' boot option\n");
 		panic("Out of memory");
 	} else {
 		hotplug_memory_notifier(page_cgroup_callback, 0);
 	}
 	printk(KERN_INFO "allocated %ld bytes of page_cgroup\n", total_usage);
-	printk(KERN_INFO "please try cgroup_disable=memory option if you don't"
-	" want\n");
+	printk(KERN_INFO "please try 'cgroup_disable=memory' option if you don't"
+	" want memory cgroups\n");
 }
 
 void __meminit pgdat_page_cgroup_init(struct pglist_data *pgdat)

MAINTAINERS L: [email protected] · line 1521

Quoted 3 lines

MAINTAINERS +0 -0

@@ -1519,6 +1519,7 @@ L:	[email protected]
 S:	Maintained
 F:	include/linux/cgroup*
 F:	kernel/cgroup*

May be we should fix it like this:

F: include/linux/cgroup.h
F: kernel/cgroup.c
F: kernel/cgroup_debug.c

Since the authors of kernel/cgroup_freezer.c are Matt Helsley <[email protected]> and Cedric Le Goater <[email protected]>.

And the author of net/sched/cls_cgroup.c is Thomas Graf <[email protected]>,

And the maintainer of kernel/ns_cgroup.c and security/device_cgroup.c is Serge E. Hallyn <[email protected]>.

MAINTAINERS L: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org · line 1523

Quoted 2 lines

MAINTAINERS +1 -0
+F:	mm/*cgroup*
 

And this belongs to memory resource controller (grep 'MEMORY RESOURCE CONTROLLER' in MAINTAINERS). The maintainers of mm/page_cgroup.c and mm/memcontrol.c are Balbir and Kamezawa.

Quoted 4 lines

MAINTAINERS +0 -0

 CORETEMP HARDWARE MONITORING DRIVER
 P:	Rudolf Marek

Li Zefan

2009-05-04 01:28 UTC #3 lore raw

In reply to a message not in the archive

(sorry for the delayed reply)

Quoted 51 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix some cgroup messages to read better.
Update MAINTAINERS to include mm/*cgroup* files.

Signed-off-by Randy Dunlap <[email protected]>

---
 MAINTAINERS      |    1 +
 mm/page_cgroup.c |   14 +++++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)

mm/page_cgroup.c +7 -7

@@ -83,12 +83,12 @@ void __init page_cgroup_init(void)
 			goto fail;
 	}
 	printk(KERN_INFO "allocated %ld bytes of page_cgroup\n", total_usage);
-	printk(KERN_INFO "please try cgroup_disable=memory option if you"
-	" don't want\n");
+	printk(KERN_INFO "please try 'cgroup_disable=memory' option if you"
+	" don't want memory cgroups\n");
 	return;
 fail:
-	printk(KERN_CRIT "allocation of page_cgroup was failed.\n");
-	printk(KERN_CRIT "please try cgroup_disable=memory boot option\n");
+	printk(KERN_CRIT "allocation of page_cgroup failed.\n");
+	printk(KERN_CRIT "please try 'cgroup_disable=memory' boot option\n");
 	panic("Out of memory");
 }

@@ -257,14 +257,14 @@ void __init page_cgroup_init(void)
 		fail = init_section_page_cgroup(pfn);
 	}
 	if (fail) {
-		printk(KERN_CRIT "try cgroup_disable=memory boot option\n");
+		printk(KERN_CRIT "try 'cgroup_disable=memory' boot option\n");
 		panic("Out of memory");
 	} else {
 		hotplug_memory_notifier(page_cgroup_callback, 0);
 	}
 	printk(KERN_INFO "allocated %ld bytes of page_cgroup\n", total_usage);
-	printk(KERN_INFO "please try cgroup_disable=memory option if you don't"
-	" want\n");
+	printk(KERN_INFO "please try 'cgroup_disable=memory' option if you don't"
+	" want memory cgroups\n");
 }
 
 void __meminit pgdat_page_cgroup_init(struct pglist_data *pgdat)

MAINTAINERS L: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org · line 1521

Quoted 3 lines

MAINTAINERS +0 -0

@@ -1519,6 +1519,7 @@ L:	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
 S:	Maintained
 F:	include/linux/cgroup*
 F:	kernel/cgroup*

May be we should fix it like this:

F: include/linux/cgroup.h
F: kernel/cgroup.c
F: kernel/cgroup_debug.c

Since the authors of kernel/cgroup_freezer.c are Matt Helsley <matthltc-r/[email protected]> and Cedric Le Goater <clg-NmTC/[email protected]>.

And the author of net/sched/cls_cgroup.c is Thomas Graf <tgraf-G/[email protected]>,

And the maintainer of kernel/ns_cgroup.c and security/device_cgroup.c is Serge E. Hallyn <serue-r/[email protected]>.

MAINTAINERS L: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org · line 1523

Quoted 2 lines

MAINTAINERS +1 -0
+F:	mm/*cgroup*
 

And this belongs to memory resource controller (grep 'MEMORY RESOURCE CONTROLLER' in MAINTAINERS). The maintainers of mm/page_cgroup.c and mm/memcontrol.c are Balbir and Kamezawa.

Quoted 4 lines

MAINTAINERS +0 -0

 CORETEMP HARDWARE MONITORING DRIVER
 P:	Rudolf Marek