Skip to contentSkip to conversation

Adding mount option to kernel for NFS filesystem

DISCUSSION Gertjan Oude Lohuis 2 participants 2 messages Apr 29, 2009 – Apr 30, 2009 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi guys,

For fun and learning purposes I'm trying to add an mountflag for NFS-mounts to the kernel and mount. The flag's semantics are identical to ac/noac: 'flag' is default but has no special meaning, 'noflag' triggers a certain action.

I have a small question about adding the flag to include/linux/nfs_mount.h. Since NFS_MOUNT_FLAGMASK is defined as 0xFFFF, and all bits up until 0xFFFF are occupied by existing NFS_MOUNT-flags, how could I add my own flag?
Would it be ok to define NFS_MOUNT_FLAGMASK as 0xFFFFF and my own flag as 0x10000? Or will this have other side effects? It seems to be working though ;-).
How would this be done if a real flag should be added by kernel maintainers?

I guess another option would be to create a new entry in the nfs_mount_data struct and treat it as an option (rsize-, wsize-, timeo-alike), but I'd like to do keep it the same as other flags.

Please advice! ;-)
Thanks in advance for your time.

Sincerely,
Gertjan

#2 lore raw
In reply to a message not in the archive
Quoted 20 lines · On Wed, 29 Apr 2009 19:03:06 +0200 Gertjan Oude Lohuis…

Hi guys,

For fun and learning purposes I'm trying to add an mountflag for NFS-mounts to the kernel and mount. The flag's semantics are identical to ac/noac: 'flag' is default but has no special meaning, 'noflag' triggers a certain action.

I have a small question about adding the flag to include/linux/nfs_mount.h. Since NFS_MOUNT_FLAGMASK is defined as 0xFFFF, and all bits up until 0xFFFF are occupied by existing NFS_MOUNT-flags, how could I add my own flag?
Would it be ok to define NFS_MOUNT_FLAGMASK as 0xFFFFF and my own flag as 0x10000? Or will this have other side effects? It seems to be working though ;-).
How would this be done if a real flag should be added by kernel maintainers?

I guess another option would be to create a new entry in the nfs_mount_data struct and treat it as an option (rsize-, wsize-, timeo-alike), but I'd like to do keep it the same as other flags.

Quoted 6 lines

Please advice! ;-)
Thanks in advance for your time.

Sincerely,
Gertjan

It's probably better to post questions like this to linux-nfs-u79uwXL29TaiAVqoAR/[email protected] cc'ing that on the response...

Newer kernels and mount.nfs progs use text-based mount options by default. My suggestion would be to avoid worrying about the legacy mount option code and to just make the new option work with the text based ones only.

Cheers,

Signature · 5 lines
Jeff Layton <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html