ixgbe: removing unnecesary assignments
Subsystems (2)
PATCH 1/1 ixgbe: removing unnecesary assignments
This patch removes some assignment that are not necessary. Since the ret variable is declared as false during its initialization, it makes no sense to reassign false to it again.
Signed-off-by Breno Leitao <[email protected]>
--- drivers/net/ixgbe/ixgbe_main.c | 12 ------------ 1 files changed, 0 insertions(+), 12 deletions(-)
drivers/net/ixgbe/ixgbe_main.c +0 -12
@@ -2775,8 +2775,6 @@ static inline bool ixgbe_set_dcb_queues(struct ixgbe_adapter *adapter) adapter->num_tx_queues = adapter->ring_feature[RING_F_DCB ].indices; ret = true; - }else { - ret = false; }return ret;
@@ -2802,8 +2800,6 @@ static inline bool ixgbe_set_rss_queues(struct ixgbe_adapter *adapter) adapter->num_tx_queues = adapter->ring_feature[RING_F_RSS ].indices; ret = true; - }else { - ret = false; }return ret;
@@ -2910,8 +2906,6 @@ static inline bool ixgbe_cache_ring_rss(struct ixgbe_adapter *adapter)for (i =0 ; i < adapter->num_tx_queues; i++) adapter->tx_ring[i].reg_idx = i; ret = true; - }else { - ret = false; }return ret;
@@ -2986,14 +2980,8 @@ static inline bool ixgbe_cache_ring_dcb(struct ixgbe_adapter *adapter) adapter->rx_ring[i].reg_idx = i <<5 ; ret = true; - }else { - ret = false; } - }else { - ret = false; } - }else { - ret = false; }return ret;
Signature · 9 lines
1.6.0.2 ------------------------------------------------------------------------------ Register Now & Save for Velocity, the Web Performance & Operations Conference from O'Reilly Media. Velocity features a full day of expert-led, hands-on workshops and two days of sessions from industry leaders in dedicated Performance & Operations tracks. Use code vel09scf and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
Quoted 7 lines · Breno Leitao
This patch removes some assignment that are not necessary. Since the ret variable is declared as false during its initialization, it makes no sense to reassign false to it again.
Signed-off-by Breno Leitao <[email protected]>---
Thanks Breno, I have added the patch to my queue of ixgbe patches. I will push it with the other ixgbe patches I have, thanks again.
Signature · 9 lines
Cheers, Jeff ------------------------------------------------------------------------------ Register Now & Save for Velocity, the Web Performance & Operations Conference from O'Reilly Media. Velocity features a full day of expert-led, hands-on workshops and two days of sessions from industry leaders in dedicated Performance & Operations tracks. Use code vel09scf and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf