Skip to contentSkip to conversation

remove dynamic libiptc.so from iptables-static

PATCH In review Ben Gardiner 2 participants 2 messages May 6, 2009 – Jun 1, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove dynamic libiptc.so from iptables-static

I was building iptables-static from 1.4.3.2 and I noticed that ldd reported libiptc.so was a dependency; I was using gcc 4.0.1 for ppc cross compile -- but I don't think the toolchain is the cause. I was able to get iptables-static to depend only on libm and libc with the following patch (made against the 1.4.3.2 dist, but applies clean to svn trunk). I hope you will consider it for inclusion in the next release.

Thanks,
Ben Gardiner

Makefile.am +0 -0
index fd99098..80ee250 100644
@@ -15,7 +15,12 @@ lib_LTLIBRARIES =
 
# libiptc
lib_LTLIBRARIES           += libiptc/libiptc.la
-libiptc_libiptc_la_SOURCES = libiptc/libip4tc.c libiptc/libip6tc.c
+if ENABLE_IPV4
+libiptc_libiptc_la_SOURCES = libiptc/libip4tc.c
+endif
+if ENABLE_IPV6
+libiptc_libiptc_la_SOURCES = libiptc/libip6tc.c
+endif
libiptc_libiptc_la_LDFLAGS = -version-info 0:0:0

lib_LTLIBRARIES += libxtables.la
@@ -44,10 +49,10 @@ iptables_save_SOURCES = iptables-save.c iptables.c
iptables_save_LDFLAGS = ${iptables_LDFLAGS}
iptables_save_LDADD = ${iptables_LDADD}

-# iptables-multi, semi-static
-iptables_static_SOURCES = ${iptables_multi_SOURCES} xtables.c
+# iptables-static
+iptables_static_SOURCES = ${iptables_multi_SOURCES} xtables.c ${libiptc_libiptc_la_SOURCES}
iptables_static_CFLAGS = ${iptables_multi_CFLAGS} -DNO_SHARED_LIBS=1
-iptables_static_LDADD = libiptc/libiptc.la extensions/libext4.a -lm
+iptables_static_LDADD = extensions/libext4.a -lm

iptables_xml_SOURCES = iptables-xml.c

begin:vcard
fn:Ben Gardiner
n:Gardiner;Ben
org:Nanometrics Seismological Instruments;Software R&D adr:;;250 Herzberg Rd.;Kanata;ON;K2K 2A1;Canada email;internet:[email protected] title:M.Sc. Eng.
tel;work:613 592 6776 x239
tel;fax:613 592 5929
x-mozilla-html:FALSE
url:www.nanometrics.ca
version:2.1
end:vcard

#1 lore raw
Quoted 4 lines · Ben Gardiner

I was building iptables-static from 1.4.3.2 and I noticed that ldd reported libiptc.so was a dependency; I was using gcc 4.0.1 for ppc cross compile -- but I don't think the toolchain is the cause.

This is intentional. "static" here means that all the extensions are included; we certainly do not want a truly static binary where ldd would report "not a dynamic executable".

Quoted 14 lines

I was able to get iptables-static to depend only on libm and libc with the following patch (made against the 1.4.3.2 dist, but applies clean to svn trunk). I hope you will consider it for inclusion in the next release.

# libiptc
lib_LTLIBRARIES           += libiptc/libiptc.la
(quoted diff) +6 -1
-libiptc_libiptc_la_SOURCES = libiptc/libip4tc.c libiptc/libip6tc.c
+if ENABLE_IPV4
+libiptc_libiptc_la_SOURCES = libiptc/libip4tc.c
+endif
+if ENABLE_IPV6
+libiptc_libiptc_la_SOURCES = libiptc/libip6tc.c
+endif
Quoted 1 line

libiptc_libiptc_la_LDFLAGS = -version-info 0:0:0

If both ENABLE_IPV4=1, ENABLE_IPV6=1, it won't do the right thing anymore.

Quoted 14 lines

lib_LTLIBRARIES += libxtables.la

(quoted diff) +2 -2
@@ -44,10 +49,10 @@ iptables_save_SOURCES     = iptables-save.c iptables.c
 iptables_save_LDFLAGS     = ${iptables_LDFLAGS}
 iptables_save_LDADD       = ${iptables_LDADD}
 
-# iptables-multi, semi-static
-iptables_static_SOURCES   = ${iptables_multi_SOURCES} xtables.c
+# iptables-static
+iptables_static_SOURCES   = ${iptables_multi_SOURCES} xtables.c
 ${libiptc_libiptc_la_SOURCES}

iptables_static_CFLAGS = ${iptables_multi_CFLAGS} -DNO_SHARED_LIBS=1

(quoted diff) +1 -1
-iptables_static_LDADD     = libiptc/libiptc.la extensions/libext4.a -lm
+iptables_static_LDADD     = extensions/libext4.a -lm
Quoted 1 line

iptables_xml_SOURCES = iptables-xml.c

Not needed - just run ./configure --disable-shared.