Skip to contentSkip to conversation

xfstests 042: point xfs_fsr right at the fragmented file

PATCH In review Eric Sandeen 2 participants 3 messages May 8, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests 042: point xfs_fsr right at the fragmented file

Somehow 042 as it stands isn't actually defragging the fragmented file we created (see 042.full post-run)

Probably need to look into that as well, but for now this should make the call to fsr actually _do_ something.

This has let 2 fsr bugs slip through qa in the past few months. :(

---

042 +1 -1
index 6628040..1ad81e4 100755
@@ -114,7 +114,7 @@ _do "sum $SCRATCH_MNT/fragmented >$tmp.sum1"
 _do "Remove other files" "rm -rf $SCRATCH_MNT/{pad,hole*}"
 
 # defragment
-_do "Run xfs_fsr on filesystem" "$XFS_FSR_PROG -v $SCRATCH_DEV"
+_do "Run xfs_fsr on filesystem" "$XFS_FSR_PROG -v $SCRATCH_MNT/fragmented"
 _do "xfs_bmap -v $SCRATCH_MNT/fragmented"
 _do "Check 4k files" "src/fill2fs_check $tmp.manifest"
 

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 7 lines · Eric Sandeen

Somehow 042 as it stands isn't actually defragging the fragmented file we created (see 042.full post-run)

Probably need to look into that as well, but for now this should make the call to fsr actually _do_ something.

This has let 2 fsr bugs slip through qa in the past few months. :(

Looks good. Can you open a bugzilla for the problem of fsr not actually finding the fragmented file so that we don't forget about that one?

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 4 lines · Christoph Hellwig
Quoted 3 lines · Eric Sandeen

Somehow 042 as it stands isn't actually defragging the fragmented file we created (see 042.full post-run)

Quoted 8 lines
Quoted 4 lines

Probably need to look into that as well, but for now this should make the call to fsr actually _do_ something.

This has let 2 fsr bugs slip through qa in the past few months. :(

Looks good. Can you open a bugzilla for the problem of fsr not actually finding the fragmented file so that we don't forget about that one?

Good idea and done: http://oss.sgi.com/bugzilla/show_bug.cgi?id=821

-Eric

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs