Skip to contentSkip to conversation

blktrace: pdu_buf of pc events should be unsigned

PATCH In review Li Zefan 1 participant 2 messages May 11, 2009

Subsystems (2)
lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 blktrace: pdu_buf of pc events should be unsigned

I got this:
8,0 1 305.417782332 2037 I R 32 (ffffff9e 10 00 ...) [bash]

It should be:
8,0 1 305.417782332 2037 I R 32 (9e 10 00 ...) [bash]

[ Impact: fix output of pc events ]

---
 kernel/trace/blktrace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/trace/blktrace.c +1 -1
index c223cd1..9c5a951 100644
@@ -1071,7 +1071,7 @@ static int blk_log_action(struct trace_iterator *iter, const char *act)
 
 static int blk_log_dump_pdu(struct trace_seq *s, const struct trace_entry *ent)
 {
-	const char *pdu_buf;
+	const unsigned char *pdu_buf;
 	int pdu_len;
 	int i, end, ret;
 
Signature · 1 line
1.5.4.rc3
#1 lore raw
Commit-ID:  049862579333cc6cd9e6edfd6987cd0addfd8c59
Gitweb:     http://git.kernel.org/tip/049862579333cc6cd9e6edfd6987cd0addfd8c59
Author:     Li Zefan <[email protected]>
AuthorDate: Mon, 11 May 2009 14:33:23 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 11 May 2009 12:25:50 +0200

blktrace: pdu_buf of pc events should be unsigned

I got this:
8,0 1 305.417782332 2037 I R 32 (ffffff9e 10 00 ...) [bash]

It should be:
8,0 1 305.417782332 2037 I R 32 (9e 10 00 ...) [bash]

[ Impact: fix output of pc events ]

Cc Jens Axboe <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Steven Rostedt <[email protected]>
Cc Frederic Weisbecker <[email protected]>

LKML-Reference: <[email protected]>

---
 kernel/trace/blktrace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/trace/blktrace.c +1 -1
index e099f8c..05b4747 100644
@@ -1065,7 +1065,7 @@ static int blk_log_action(struct trace_iterator *iter, const char *act)
 
 static int blk_log_dump_pdu(struct trace_seq *s, const struct trace_entry *ent)
 {
-	const char *pdu_buf;
+	const unsigned char *pdu_buf;
 	int pdu_len;
 	int i, end, ret;