Skip to contentSkip to conversation

sctp: check the unrecognized ASCONF parameter before access

PATCH Superseded Wei Yongjun 2 participants 2 messages May 12, 2009

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sctp: check the unrecognized ASCONF parameter before access

This patch fix to check the unrecognized ASCONF parameter before access it.

---
 net/sctp/sm_make_chunk.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
net/sctp/sm_make_chunk.c +5 -0
index 61cc607..ab91712 100644
@@ -2861,6 +2861,11 @@ static __be16 sctp_process_asconf_param(struct sctp_association *asoc,
 	addr_param = (union sctp_addr_param *)
 			((void *)asconf_param + sizeof(sctp_addip_param_t));
 
+	if (asconf_param->param_hdr.type != SCTP_PARAM_ADD_IP &&
+	    asconf_param->param_hdr.type != SCTP_PARAM_DEL_IP &&
+	    asconf_param->param_hdr.type != SCTP_PARAM_SET_PRIMARY)
+		return SCTP_ERROR_UNKNOWN_PARAM;
+
 	switch (addr_param->v4.param_hdr.type) {
 	case SCTP_PARAM_IPV6_ADDRESS:
 		if (!asoc->peer.ipv6_address)
Signature · 1 line
1.5.3.8
#1 lore raw

Re: [PATCH] sctp: check the unrecognized ASCONF parameter before

Quoted 14 lines · Wei Yongjun

This patch fix to check the unrecognized ASCONF parameter before access it.

---
 net/sctp/sm_make_chunk.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
net/sctp/sm_make_chunk.c +0 -0
index 61cc607..ab91712 100644
@@ -2861,6 +2861,11 @@ static __be16 sctp_process_asconf_param(struct sctp_association *asoc,
 	addr_param = (union sctp_addr_param *)

net/sctp/sm_make_chunk.c static __be16 sctp_process_asconf_param(struct sctp_association *asoc, · line 2871

Quoted 10 lines
net/sctp/sm_make_chunk.c +5 -0
 			((void *)asconf_param + sizeof(sctp_addip_param_t));
 
+	if (asconf_param->param_hdr.type != SCTP_PARAM_ADD_IP &&
+	    asconf_param->param_hdr.type != SCTP_PARAM_DEL_IP &&
+	    asconf_param->param_hdr.type != SCTP_PARAM_SET_PRIMARY)
+		return SCTP_ERROR_UNKNOWN_PARAM;
+
 	switch (addr_param->v4.param_hdr.type) {
 	case SCTP_PARAM_IPV6_ADDRESS:
 		if (!asoc->peer.ipv6_address)

Clean up the 'default' case, since it now becomes dead code.

-vlad