Skip to contentSkip to conversation

Neterion: *FIFO1_DMA_ERR set twice, should 2nd be *FIFO2_DMA_ERR?

PATCH Applied Roel Kluin 3 participants 3 messages May 15, 2009 – May 18, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 Neterion: *FIFO1_DMA_ERR set twice, should 2nd be *FIFO2_DMA_ERR?

FIFO1_DMA_ERR is set twice, the second should be FIFO2_DMA_ERR.

Signed-off-by Roel Kluin <[email protected]>

---
Correct? Please review.

drivers/net/vxge/vxge-traffic.c +1 -1
index 7be0ae1..c2eeac4 100644
@@ -115,7 +115,7 @@ enum vxge_hw_status vxge_hw_vpath_intr_enable(struct __vxge_hw_vpath_handle *vp)
 		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_POISON|
 		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_POISON|
 		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR|
-		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR), 0, 32),
+		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_DMA_ERR), 0, 32),
 		&vp_reg->kdfcctl_errors_mask);
 
 	__vxge_hw_pio_mem_write32_upper(0, &vp_reg->vpath_ppif_int_mask);
Acked-by Ram Vepa on v1 1/1
#1 lore raw

drivers/net/vxge/vxge-traffic.c enum vxge_hw_status

Quoted 12 lines

FIFO1_DMA_ERR is set twice, the second should be FIFO2_DMA_ERR.

Signed-off-by Roel Kluin <[email protected]>

---
Correct? Please review.

drivers/net/vxge/vxge- renamed from drivers/net/vxge/vxge-traffic.c +0 -0

traffic.c
index 7be0ae1..c2eeac4 100644

drivers/net/vxge/vxge-traffic.c +0 -0
@@ -115,7 +115,7 @@ enum vxge_hw_status

vxge_hw_vpath_intr_enable(struct

drivers/net/vxge/vxge-traffic.c enum vxge_hw_status vxge_hw_vpath_intr_enable(struct __vxge_hw_vpath_handle *vp)

Quoted 5 lines
drivers/net/vxge/vxge-traffic.c +0 -1
 __vxge_hw_vpath_handle *vp)
 		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_POISON|
 		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_POISON|
 		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR|
-		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR), 0,

32),

drivers/net/vxge/vxge-traffic.c enum vxge_hw_status · line 119

Quoted 1 line
drivers/net/vxge/vxge-traffic.c +1 -0
+		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_DMA_ERR), 0,

32),

Quoted 3 lines
drivers/net/vxge/vxge-traffic.c +0 -0
 		&vp_reg->kdfcctl_errors_mask);

__vxge_hw_pio_mem_write32_upper(0,

&vp_reg->vpath_ppif_int_mask);
[Ram] Good catch!

Acked-by Ram Vepa <[email protected]>

Thanks,
Ram