Skip to contentSkip to conversation

X:beyond ARRAY_SIZE of ib->btx_ring

PATCH New Roel Kluin 2 participants 4 messages May 21, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 X:beyond ARRAY_SIZE of ib->btx_ring

Do not go beyond ARRAY_SIZE of ib->btx_ring

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/sunlance.c +1 -1
index 704301a..aa2a4ef 100644
@@ -343,7 +343,7 @@ static void lance_init_ring_dvma(struct net_device *dev)
 	ib->phys_addr [5] = dev->dev_addr [4];
 
 	/* Setup the Tx ring entries */
-	for (i = 0; i <= TX_RING_SIZE; i++) {
+	for (i = 0; i < TX_RING_SIZE; i++) {
 		leptr = LANCE_ADDR(aib + libbuff_offset(tx_buf, i));
 		ib->btx_ring [i].tmd0      = leptr;
 		ib->btx_ring [i].tmd1_hadr = leptr >> 16;
author
#1 lore raw

PATCH 1/1 sunlance: beyond ARRAY_SIZE of ib->btx_ring

Do not go beyond ARRAY_SIZE of ib->btx_ring

Signed-off-by Roel Kluin <[email protected]>

---
Please ignore the other "X: ... patch"

drivers/net/sunlance.c +2 -2
index 704301a..e7f1178 100644
@@ -343,7 +343,7 @@ static void lance_init_ring_dvma(struct net_device *dev)
 	ib->phys_addr [5] = dev->dev_addr [4];
 
 	/* Setup the Tx ring entries */
-	for (i = 0; i <= TX_RING_SIZE; i++) {
+	for (i = 0; i < TX_RING_SIZE; i++) {
 		leptr = LANCE_ADDR(aib + libbuff_offset(tx_buf, i));
 		ib->btx_ring [i].tmd0      = leptr;
 		ib->btx_ring [i].tmd1_hadr = leptr >> 16;

@@ -399,7 +399,7 @@ static void lance_init_ring_pio(struct net_device *dev)
 	sbus_writeb(dev->dev_addr[4], &ib->phys_addr[5]);
 
 	/* Setup the Tx ring entries */
-	for (i = 0; i <= TX_RING_SIZE; i++) {
+	for (i = 0; i < TX_RING_SIZE; i++) {
 		leptr = libbuff_offset(tx_buf, i);
 		sbus_writew(leptr,	&ib->btx_ring [i].tmd0);
 		sbus_writeb(leptr >> 16,&ib->btx_ring [i].tmd1_hadr);
maintainer
#2 lore raw

Re: [PATCH] sunlance: beyond ARRAY_SIZE of ib->btx_ring

From: Roel Kluin <[email protected]>
Date: Thu, 21 May 2009 22:31:12 +0200

Quoted 5 lines

Do not go beyond ARRAY_SIZE of ib->btx_ring

Signed-off-by Roel Kluin <[email protected]>

---
Please ignore the other "X: ... patch"

You don't need to keep CC:'ing Jeff, he hasn't handled networking device driver patches for some time now.

maintainer
#3 lore raw

Re: [PATCH] sunlance: beyond ARRAY_SIZE of ib->btx_ring

In reply to Roel Kluin

From: Roel Kluin <[email protected]>
Date: Thu, 21 May 2009 22:31:12 +0200

Quoted 3 lines

Do not go beyond ARRAY_SIZE of ib->btx_ring

Signed-off-by Roel Kluin <[email protected]>

What in the world are you generating this patch against?

Linus's tree already has this change, for months.

And it was added by you, in February!

commit b956d41162b1f2c4b446107e9910e4719cbc75f4

Author: Roel Kluin <[email protected]>
Date:   Sat Feb 21 23:46:36 2009 -0800

sunlance: Beyond ARRAY_SIZE of ib->btx_ring

Do not go beyond ARRAY_SIZE of ib->btx_ring

Signed-off-by Roel Kluin <[email protected]>
Signed-off-by David S. Miller <[email protected]>