Skip to contentSkip to conversation

gigaset: beyond ARRAY_SIZE of iwb->data

PATCH Applied Roel Kluin 3 participants 3 messages May 21, 2009 – May 25, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 gigaset: beyond ARRAY_SIZE of iwb->data

Do not go beyond ARRAY_SIZE of iwb->data

Signed-off-by Roel Kluin <[email protected]>

---
Sorry for the dup, the header was incorrect. This is against linux-next.

drivers/isdn/gigaset/isocdata.c +1 -1
index fbce522..5569a6e 100644
@@ -177,7 +177,7 @@ int gigaset_isowbuf_getbytes(struct isowbuf_t *iwb, int size)
 		return -EINVAL;
 	}
 	src = iwb->read;
-	if (unlikely(limit > BAS_OUTBUFSIZE + BAS_OUTBUFPAD ||
+	if (unlikely(limit >= BAS_OUTBUFSIZE + BAS_OUTBUFPAD ||
 		     (read < src && limit >= src))) {
 		err("isoc write buffer frame reservation violated");
 		return -EFAULT;
#2 lore raw

Am 22.05.2009 00:04 schrieb David Miller:

Quoted 10 lines

From: Roel Kluin <[email protected]>
Date: Thu, 21 May 2009 22:32:54 +0200

Quoted 5 lines

Do not go beyond ARRAY_SIZE of iwb->data

Signed-off-by Roel Kluin <[email protected]>

---
Sorry for the dup, the header was incorrect. This is against linux-next.

Applied to net-2.6

Thanks for the CC. Unfortunately I didn't receive the original patch, nor can I find it on LKML. Could someone send me a copy please so that I can check it before it gets merged?

Thanks,
Tilman

Signature · 4 lines
Tilman Schmidt                    E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)