90kernel-modules-loaded must be --hostonly

/sbin/lsmod | while read mod rest; do
instmods "$mod"
done

[ -f /etc/modprobe.conf ] && dracut_install /etc/modprobe.conf dracut_install $(find /etc/modprobe.d/ -type f )

Quoted 3 lines

/sbin/lsmod | while read mod rest; do
instmods "$mod"
done

This part relies on looking at the running system, and thus must not be part of the default dracut run. This seems OK for --hostonly mode.

Changing this will likely break some users depending on modules not otherwise pulled in elsewhere? Should I just go ahead and see what breaks?

Quoted 4 lines

[ -f /etc/modprobe.conf ] && dracut_install /etc/modprobe.conf dracut_install $(find /etc/modprobe.d/ -type f )

This part is fine.

Quoted 10 lines · Warren Togami

Quoted 3 lines

/sbin/lsmod | while read mod rest; do
instmods "$mod"
done

This part relies on looking at the running system, and thus must not be part of the default dracut run. This seems OK for --hostonly mode.

Changing this will likely break some users depending on modules not otherwise pulled in elsewhere? Should I just go ahead and see what breaks?

Oh, I now notice that the check script skips this entirely unless you are in hostonly mode. This is the reason why I'm not getting the KMS drivers loaded prior to plymouth (although plymouth itself is still busted for other reasons.)

[ "$1" != "-h" ] && exit 1

But is this correct? It seems we should be checking the hostonly variable and not if "-h" happens to be the first parameter.

Quoted 19 lines · Warren Togami

Quoted 10 lines · Warren Togami

Quoted 3 lines

/sbin/lsmod | while read mod rest; do
instmods "$mod"
done

This part relies on looking at the running system, and thus must not be part of the default dracut run. This seems OK for --hostonly mode.

Changing this will likely break some users depending on modules not otherwise pulled in elsewhere? Should I just go ahead and see what breaks?

Oh, I now notice that the check script skips this entirely unless you are in hostonly mode. This is the reason why I'm not getting the KMS drivers loaded prior to plymouth (although plymouth itself is still busted for other reasons.)

[ "$1" != "-h" ] && exit 1

Review

Quoted 5 lines

But is this correct? It seems we should be checking the hostonly variable and not if "-h" happens to be the first parameter.

(quoted diff) +0 -2

-h isn't -H.
-h isn't --hostonly

This obviously broke by introducing the --help option.. just fix it.