Skip to contentSkip to conversation

xfstests: don't run 122 if required headers aren't found

PATCH In review Eric Sandeen 2 participants 3 messages Jun 3, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: don't run 122 if required headers aren't found

Now that libxfs etc is optional, 122 (which compiles on the fly) is failing if those extra headers are missing.

---

122 +2 -1
index 7123753..9fbe437 100755
@@ -191,7 +191,8 @@ awk '
 echo 'return 0; }' >>$cprog
 
 # create and run program
-cc -o $oprog $cprog
+cc -o $oprog $cprog >> $seq.full 2>&1 || \
+  _notrun "Could not compile test program (see end of $seq.full)"
 $oprog | _type_size_filter > $progout
 
 #

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by
#2 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 2 lines · Eric Sandeen

Now that libxfs etc is optional, 122 (which compiles on the fly) is failing if those extra headers are missing.

Oh, the great 122 tests. Indeed without all the headers defining the structures we can't actually check their size.

Umm, should be:

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs