Skip to contentSkip to conversation

sony-laptop: no need to unblock rfkill on load

PATCH In review Alan Jenkins 4 participants 6 messages Jun 8, 2009 – Jun 9, 2009 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sony-laptop: no need to unblock rfkill on load

The re-written rfkill core ensures rfkill devices are initialized to the system default state. The core calls set_block after registration so the driver shouldn't need to.

---

This patch applies on top of the rfkill rewrite in the wireless-testing tree.

drivers/platform/x86/sony-laptop.c +0 -1
index aec0b27..c1b21a4 100644
@@ -1114,7 +1114,6 @@ static int sony_nc_setup_rfkill(struct acpi_device *device,
 		return err;
 	}
 	sony_rfkill_devices[nc_type] = rfk;
-	sony_nc_rfkill_set((void *)nc_type, false);
 	return err;
 }
 

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw
Quoted 5 lines · Alan Jenkins

The re-written rfkill core ensures rfkill devices are initialized to the system default state. The core calls set_block after registration so the driver shouldn't need to.

Good catch, thanks.

Quoted 18 lines

---

This patch applies on top of the rfkill rewrite in the wireless-testing tree.

drivers/platform/x86/sony-laptop.c +0 -1
index aec0b27..c1b21a4 100644
@@ -1114,7 +1114,6 @@ static int sony_nc_setup_rfkill(struct acpi_device *device,
 		return err;
 	}
 	sony_rfkill_devices[nc_type] = rfk;
-	sony_nc_rfkill_set((void *)nc_type, false);
 	return err;
 }
 
#3 lore raw
In reply to a message not in the archive
Quoted 8 lines · Johannes Berg
Quoted 5 lines · Alan Jenkins

The re-written rfkill core ensures rfkill devices are initialized to the system default state. The core calls set_block after registration so the driver shouldn't need to.

Good catch, thanks.

Just to confirm, is this patch going to sit in the wireless-testing tree and you will submit it for inclusion together with the rfkill work right?

Quoted 4 lines
Quoted 4 lines

---

This patch applies on top of the rfkill rewrite in the wireless-testing tree.

Quoted 14 lines
Quoted 7 lines
drivers/platform/x86/sony-laptop.c +0 -0
index aec0b27..c1b21a4 100644

drivers/platform/x86/sony-laptop.c static int sony_nc_setup_rfkill(struct acpi_device *device, · line 1119

Quoted 7 lines
drivers/platform/x86/sony-laptop.c +0 -1
@@ -1114,7 +1114,6 @@ static int sony_nc_setup_rfkill(struct acpi_device *device,
 		return err;
 	}
 	sony_rfkill_devices[nc_type] = rfk;
-	sony_nc_rfkill_set((void *)nc_type, false);
 	return err;
 }
 

thanks

Signature · 2 lines
mattia
:wq!
#5 lore raw
In reply to a message not in the archive
Quoted 8 lines · Mattia Dongili
Quoted 6 lines · Johannes Berg
Quoted 4 lines · Alan Jenkins

The re-written rfkill core ensures rfkill devices are initialized to the system default state. The core calls set_block after registration so the driver shouldn't need to.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

Good catch, thanks.

Just to confirm, is this patch going to sit in the wireless-testing tree and you will submit it for inclusion together with the rfkill work right?

Yes. I probably didn't need to ping you at this point.

It just bothered me because I was effectively reverting a recent commit. I figuired I should let you know. In case it didn't work, when it was merged you'd know why I did it and who to blame. But there is always Git history for that :-).

Regards
Alan

maintainer
#6 lore raw
Quoted 19 lines · Alan Jenkins
Quoted 8 lines · Mattia Dongili
Quoted 6 lines · Johannes Berg
Quoted 4 lines · Alan Jenkins

The re-written rfkill core ensures rfkill devices are initialized to the system default state. The core calls set_block after registration so the driver shouldn't need to.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

Good catch, thanks.

Just to confirm, is this patch going to sit in the wireless-testing tree and you will submit it for inclusion together with the rfkill work right?

Quoted 6 lines

Yes. I probably didn't need to ping you at this point.

It just bothered me because I was effectively reverting a recent commit. I figuired I should let you know. In case it didn't work, when it was merged you'd know why I did it and who to blame. But there is always Git history for that :-).

Errm... now that I look at that patch more closely, the code you're modifying is not upstream either.
Anyway thanks for the ping, I'll take a look at what's going on in the wireless-testing tree ;)

cheers

Signature · 2 lines
mattia
:wq!
#7 lore raw
Quoted 9 lines · Mattia Dongili
Quoted 4 lines

It just bothered me because I was effectively reverting a recent commit. I figuired I should let you know. In case it didn't work, when it was merged you'd know why I did it and who to blame. But there is always Git history for that :-).

Errm... now that I look at that patch more closely, the code you're modifying is not upstream either.
Anyway thanks for the ping, I'll take a look at what's going on in the wireless-testing tree ;)

Sorry, I guess I forgot to copy you on the rfkill rewrite. Basically I've rewritten the rfkill APIs and ported sony. Bug
http://bugzilla.kernel.org/show_bug.cgi?id=13458 is related to that too.

johannes