Skip to contentSkip to conversation

xfstests: enable test 080 for LInux

PATCH In review Eric Sandeen 3 participants 5 messages Jun 9, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: enable test 080 for LInux

Seems to work here... Anyone know why it's disabled?

---

080 +2 -2
index e9721ad..1794a4c 100755
@@ -48,13 +48,13 @@ _supported_fs xfs
 # Apparently should be able to work on IRIX,
 # but not at the moment.
 # It does not work on Linux due to some locking issues...
-_supported_os IRIX
+_supported_os IRIX Linux
 
 [ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"
 
 _setup_testdir
 
-#quiet=-q
+quiet=-q
 clean=-c
 
 export here

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw

080 _supported_fs xfs · line 50

Quoted 13 lines · Eric Sandeen

Seems to work here... Anyone know why it's disabled?

---

080 +0 -0
index e9721ad..1794a4c 100755
@@ -48,13 +48,13 @@ _supported_fs xfs
 # Apparently should be able to work on IRIX,
 # but not at the moment.
 # It does not work on Linux due to some locking issues...

That last line of the comment should be removed I think.

080 _supported_fs xfs · line 53

Quoted 4 lines
080 +1 -1
-_supported_os IRIX
+_supported_os IRIX Linux
 
 [ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"

Given that IRIX doesn't work we should just remove it from _supported_os above.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#4 lore raw
In reply to Eric Sandeen
Quoted 16 lines · Eric Sandeen

Seems to work here... Anyone know why it's disabled?

---

080 +1 -1
index e9721ad..1794a4c 100755
@@ -48,13 +48,13 @@ _supported_fs xfs
 # Apparently should be able to work on IRIX,
 # but not at the moment.
 # It does not work on Linux due to some locking issues...
-_supported_os IRIX
+_supported_os IRIX Linux
 
Quoted 1 line

[ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"

How do these two statements fit together. If it doesn't work on IRIX, should we drop 'IRIX' from _supported_os ?

Felix

Quoted 8 lines

_setup_testdir

080 +1 -1
-#quiet=-q
+quiet=-q

clean=-c

Quoted 6 lines

export here

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
In reply to Christoph Hellwig
Quoted 5 lines · Christoph Hellwig

That last line of the comment should be removed I think.

Given that IRIX doesn't work we should just remove it from _supported_os above.

Heh, good points, here's the revised one:

Seems to work here... Anyone know why it's disabled?

---

080 +2 -5
index e9721ad..dc51c59 100755
@@ -47,14 +47,11 @@ _supported_fs xfs
 
 # Apparently should be able to work on IRIX,
 # but not at the moment.
-# It does not work on Linux due to some locking issues...
-_supported_os IRIX
-
-[ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"
+_supported_os Linux
 
 _setup_testdir
 
-#quiet=-q
+quiet=-q
 clean=-c
 
 export here

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by
#3 lore raw
Quoted 4 lines · Eric Sandeen
Quoted 2 lines · Christoph Hellwig

That last line of the comment should be removed I think.

Quoted 8 lines
Quoted 3 lines

Given that IRIX doesn't work we should just remove it from _supported_os above.

Heh, good points, here's the revised one:

Seems to work here... Anyone know why it's disabled?

Quoted 23 lines

---

080 +1 -4
index e9721ad..dc51c59 100755
@@ -47,14 +47,11 @@ _supported_fs xfs
 
 # Apparently should be able to work on IRIX,
 # but not at the moment.
-# It does not work on Linux due to some locking issues...
-_supported_os IRIX
-
-[ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"
+_supported_os Linux
 

_setup_testdir

080 +1 -1
-#quiet=-q
+quiet=-q

clean=-c

Quoted 2 lines

export here

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs