r8169: use dev_kfree_skb() instead of dev_kfree_skb_irq()

PATCH Applied Eric Dumazet 2 participants 2 messages Jun 10, 2009 – Jun 11, 2009

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Eric Dumazet

author

2009-06-10 08:56 UTC #0 lore raw

PATCH 1/1 r8169: use dev_kfree_skb() instead of dev_kfree_skb_irq()

rtl8169_tx_interrupt() is used from NAPI context, it can directly free skbs. dev_kfree_skb_irq() is a leftover from pre-NAPI times of this driver.

Signed-off-by Eric Dumazet <[email protected]>

---

drivers/net/r8169.c +1 -1

index e94316b..007c881 100644
@@ -3379,7 +3379,7 @@ static void rtl8169_tx_interrupt(struct net_device *dev,
 		rtl8169_unmap_tx_skb(tp->pci_dev, tx_skb, tp->TxDescArray + entry);
 
 		if (status & LastFrag) {
-			dev_kfree_skb_irq(tx_skb->skb);
+			dev_kfree_skb(tx_skb->skb);
 			tx_skb->skb = NULL;
 		}
 		dirty_tx++;

David Miller

maintainer Applied

2009-06-11 09:50 UTC #1 lore raw

From: Eric Dumazet <[email protected]>
Date: Wed, 10 Jun 2009 10:55:53 +0200

Quoted 5 lines

rtl8169_tx_interrupt() is used from NAPI context, it can directly free skbs. dev_kfree_skb_irq() is a leftover from pre-NAPI times of this driver.
Signed-off-by Eric Dumazet <[email protected]>

Applied.