Allow metadata correction even when PVs are missing
PATCH 1/1 Allow metadata correction even when PVs are missing
Allow metadata correction even when PVs are missing.
Signed-off-by Milan Broz <[email protected]>
--- lib/metadata/metadata.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
lib/metadata/metadata.c +4 -0
@@ -1835,6 +1835,7 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,int inconsistent_vgid =0 ;int inconsistent_pvs =0 ;unsigned use_precommitted = precommitted; +unsigned saved_handles_missing_pvs = cmd->handles_missing_pvs;struct dm_list *pvids;struct pv_list *pvl, *pvl2;struct dm_list all_pvs;
@@ -2076,11 +2077,14 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,log_warn ("WARNING: Inconsistent metadata found for VG %s - updating " "to use version %u" , vgname, correct_vg->seqno); + cmd->handles_missing_pvs =1 ;if (!vg_write (correct_vg)) {log_error ("Automatic metadata correction failed" );vg_release (correct_vg); + cmd->handles_missing_pvs = saved_handles_missing_pvs;return NULL ; } + cmd->handles_missing_pvs = saved_handles_missing_pvs;if (!vg_commit (correct_vg)) { log_error("Automatic metadata correction commit "
PATCH 1/1 Allow metadata correction even when PVs are missing
Quoted 1 line · Milan Broz
Signed-off-by Milan Broz <[email protected]>
Acked-by Petr Rockai <[email protected]>
(As discussed on IRC.)
Signature · 6 lines
Peter Rockai | me()mornfall!net | prockai()redhat!com
http://blog.mornfall.net | http://web.mornfall.net
"In My Egotistical Opinion, most people's C programs should be
indented six feet downward and covered with dirt."
-- Blair P. Houghton on the subject of C program indentationPATCH 1/1 Allow metadata correction even when PVs are missing
Same patch, with a test added (who would have guessed that the testsuite already had a test for this, just disabled since it was broken?)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: recovery-partial.diff
Type: text/x-diff
Size: 1484 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20090610/5877b929/attachment.bin>
-------------- next part --------------
Yours,
Petr.
Signature · 6 lines
Peter Rockai | me()mornfall!net | prockai()redhat!com
http://blog.mornfall.net | http://web.mornfall.net
"In My Egotistical Opinion, most people's C programs should be
indented six feet downward and covered with dirt."
-- Blair P. Houghton on the subject of C program indentation