Skip to contentSkip to conversation

xfstests: Skip dump _cleanup if filesystem is not xfs

PATCH In review Eric Sandeen 3 participants 3 messages Jun 10, 2009

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 xfstests: Skip dump _cleanup if filesystem is not xfs

Skip dump _cleanup if filesystem is not xfs

Many/most dump tests include common.dump before checking supported fs, and this means that even if the dump tests are skipped, the sleep & filesystem check in _cleanup gets run, which makes it take rather a long time to skip these tests for non-xfs filesystems.

Signed-off-by Eric Sandeen <[email protected]>

---

common.dump +6 -0
index 94de07f..d5aadfc 100644
@@ -233,6 +233,12 @@ _wipe_fs()
 #
 _cleanup()
 {
+    # Some tests include this before checking _supported_fs xfs
+    # and the sleeps & checks get annoying
+    if [ "$FSTYP" != "xfs" ]; then
+       return
+    fi
+
     cd $here
     rm -f $tmp.*

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Eric Sandeen

Skip dump _cleanup if filesystem is not xfs

Many/most dump tests include common.dump before checking supported fs, and this means that even if the dump tests are skipped, the sleep & filesystem check in _cleanup gets run, which makes it take rather a long time to skip these tests for non-xfs filesystems.

Signed-off-by Eric Sandeen <[email protected]>

---

common.dump +0 -0
index 94de07f..d5aadfc 100644

common.dump _wipe_fs() · line 240

Quoted 8 lines
common.dump +5 -0
@@ -233,6 +233,12 @@ _wipe_fs()
 #
 _cleanup()
 {
+    # Some tests include this before checking _supported_fs xfs
+    # and the sleeps & checks get annoying
+    if [ "$FSTYP" != "xfs" ]; then
+       return
+    fi

Looks good,

Reviewed-by Christoph Hellwig <[email protected]>

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#2 lore raw
In reply to Eric Sandeen
Quoted 9 lines · Eric Sandeen

Skip dump _cleanup if filesystem is not xfs

Many/most dump tests include common.dump before checking supported fs, and this means that even if the dump tests are skipped, the sleep & filesystem check in _cleanup gets run, which makes it take rather a long time to skip these tests for non-xfs filesystems.

Signed-off-by Eric Sandeen <[email protected]>
Reviewed-by Felix Blyakher <[email protected]>
Quoted 23 lines

---

common.dump +6 -0
index 94de07f..d5aadfc 100644
@@ -233,6 +233,12 @@ _wipe_fs()
 #
 _cleanup()
 {
+    # Some tests include this before checking _supported_fs xfs
+    # and the sleeps & checks get annoying
+    if [ "$FSTYP" != "xfs" ]; then
+       return
+    fi
+
    cd $here
    rm -f $tmp.*
Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs