Skip to contentSkip to conversation

net: fix network drivers ndo_start_xmit() return values (part 5)

PATCH Patrick McHardy 1 participant 1 message Jun 12, 2009

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

commit a457e7b57fba9fe2209890bb068ecae60285d0db

Author: Patrick McHardy <[email protected]>
Date:   Fri Jun 12 17:07:07 2009 +0200

net: fix network drivers ndo_start_xmit() return values (part 5)

Fix up s390 drivers that return an errno value to qdisc_restart(), causing qdisc_restart() to print a warning an requeue/retransmit the skb.

- claw: impossible condition, simply remove it

drivers/s390/net/claw.c +0 -6
index 30a43cc..7b6f46d 100644
@@ -338,12 +338,6 @@ claw_tx(struct sk_buff *skb, struct net_device *dev)
 
 	CLAW_DBF_TEXT(4, trace, "claw_tx");
         p_ch=&privptr->channel[WRITE];
-        if (skb == NULL) {
-                privptr->stats.tx_dropped++;
-		privptr->stats.tx_errors++;
-		CLAW_DBF_TEXT_(2, trace, "clawtx%d", -EIO);
-                return -EIO;
-        }
         spin_lock_irqsave(get_ccwdev_lock(p_ch->cdev), saveflags);
         rc=claw_hw_tx( skb, dev, 1 );
         spin_unlock_irqrestore(get_ccwdev_lock(p_ch->cdev), saveflags);