net: fix network drivers ndo_start_xmit() return values (part 8)
Subsystems (5)
commit 6c6e6eb6ee2b7ab91c73e51a5d7a438d2daa5b94
Author: Patrick McHardy <[email protected]> Date: Fri Jun 12 18:14:16 2009 +0200
net: fix network drivers ndo_start_xmit() return values (part 8)
Fix up USB drivers that return an errno value (result of usb_submit_urb()) to qdisc_restart(), causing qdisc_restart() to print a warning and requeue/ retransmit the skb.
- hso: skb is freed: use after free
- at76_usb: skb is freed: use after free
Compile tested only.
Signed-off-by Patrick McHardy <[email protected]>
drivers/net/usb/hso.c +1 -1
@@ -816,7 +816,7 @@ static int hso_net_start_xmit(struct sk_buff *skb, struct net_device *net) }dev_kfree_skb (skb);/* we're done */ -return result; +return NETDEV_TX_OK ; }static void hso_get_drvinfo (struct net_device *net,struct ethtool_drvinfo *info)
drivers/staging/at76_usb/at76_usb.c +3 -4
@@ -3242,12 +3242,11 @@ static int at76_tx(struct sk_buff *skb, struct net_device *netdev)"%s: -EINVAL: tx urb %p hcpriv %p complete %p\n" , priv->netdev->name, priv->tx_urb, priv->tx_urb->hcpriv, priv->tx_urb->complete); - }else { + }else stats->tx_bytes += skb->len; -dev_kfree_skb (skb); - } -return ret; +dev_kfree_skb (skb); +return NETDEV_TX_OK ; }static void at76_tx_timeout (struct net_device *netdev)