config.mk: Remove $(PCI_CLOCK) reference
PATCH 1/1 config.mk: Remove $(PCI_CLOCK) reference
The following commit introduced $(PCI_CLOCK) reference so that we could tweak `PCI_66M' definition via an environment variable.
Quoted 6 lines
commit
f046ccd15c8bc9613bfd72916b761a127d36e5c6Author: Eran Liberty <[email protected]> Date: Thu Jul 28 10:08:46 2005 -0500* Patch by Eran Liberty
Add support for the Freescale MPC8349ADS board.
But I suggest a removal of it for the following reasons:
* In 2006, MPC8349ADS was merged into MPC8349EMDS port, and it seems that MPC8349EMDS port is PCI_66M free.
* OTOH, PCI_66M is used by MPC832XEMDS an MPC8360EMDS ports, but they don't need $(PCI_CLOCK) environment variable at all. PCI_66M is automatically configured via $(BOARD)_config names with the help of $(findstring _66_,$@).
* Unfortunately $(PCI_CLOCK) has been undocumented anywhere, so only a few people know the existence of it these days.
* Keep config.mk independent from $(BOARD) as much as possible.
--- config.mk | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
config.mk +0 -4
@@ -194,10 +194,6 @@ BFD_ROOT_DIR = /opt/powerpc endif endif -ifeq ($(PCI_CLOCK),PCI_66M) -CFLAGS := $(CFLAGS) -DPCI_66M -endif - ######################################################################### export HPATH HOSTCC HOSTCFLAGS CROSS_COMPILE \
PATCH 1/1 config.mk: Remove $(PCI_CLOCK) reference
Quoted 35 lines · On Sat, 20 Jun 2009 19:10:14 +0900 Shinya Kuribayashi <[email protected]>…
The following commit introduced $(PCI_CLOCK) reference so that we could tweak `PCI_66M' definition via an environment variable.
Quoted 6 lines
commit
f046ccd15c8bc9613bfd72916b761a127d36e5c6Author: Eran Liberty <[email protected]> Date: Thu Jul 28 10:08:46 2005 -0500* Patch by Eran Liberty
Add support for the Freescale MPC8349ADS board.But I suggest a removal of it for the following reasons:
* In 2006, MPC8349ADS was merged into MPC8349EMDS port, and it seems that MPC8349EMDS port is
PCI_66Mfree.* OTOH,
PCI_66Mis used by MPC832XEMDS an MPC8360EMDS ports, but they don't need $(PCI_CLOCK) environment variable at all.PCI_66Mis automatically configured via $(BOARD)_config names with the help of $(findstring _66_,$@).* Unfortunately $(PCI_CLOCK) has been undocumented anywhere, so only a few people know the existence of it these days.
* Keep config.mk independent from $(BOARD) as much as possible.
Signed-off-by Shinya Kuribayashi <[email protected]>--- config.mk | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)config.mk +0
-0
config.mk BFD_ROOT_DIR = /opt/powerpc · line 199
Quoted 6 lines
config.mk +0
-3@@ -194,10 +194,6 @@ BFD_ROOT_DIR = /opt/powerpc endif endif -ifeq ($(PCI_CLOCK),PCI_66M) -CFLAGS := $(CFLAGS) -DPCI_66M -endif
it's all true..
$ git grep PCI_CLOCK board/xilinx/ml300/xparameters.h:#define XPAR_XPCI_CLOCK_HZ 33333333
Kim
Wolfgang Denk
AppliedPATCH 1/1 config.mk: Remove $(PCI_CLOCK) reference
In reply to Shinya KuribayashiDear Shinya Kuribayashi,
Quoted 23 lines · In message <[email protected]> you wrote:
The following commit introduced $(PCI_CLOCK) reference so that we could tweak `PCI_66M' definition via an environment variable.
Quoted 6 lines
commit
f046ccd15c8bc9613bfd72916b761a127d36e5c6Author: Eran Liberty <[email protected]> Date: Thu Jul 28 10:08:46 2005 -0500* Patch by Eran Liberty
Add support for the Freescale MPC8349ADS board.But I suggest a removal of it for the following reasons:
* In 2006, MPC8349ADS was merged into MPC8349EMDS port, and it seems that MPC8349EMDS port is
PCI_66Mfree.* OTOH,
PCI_66Mis used by MPC832XEMDS an MPC8360EMDS ports, but they don't need $(PCI_CLOCK) environment variable at all.PCI_66Mis automatically configured via $(BOARD)_config names with the help of $(findstring _66_,$@).* Unfortunately $(PCI_CLOCK) has been undocumented anywhere, so only a few people know the existence of it these days.
Quoted 6 lines
* Keep config.mk independent from $(BOARD) as much as possible.
Signed-off-by Shinya Kuribayashi <[email protected]>--- config.mk | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Killing is stupid; useless! -- McCoy, "A Private Little War", stardate 4211.8