Old style <server-ip>:/<path> not handled

DISCUSSION Warren Togami 2 participants 2 messages Jun 23, 2009 – Jun 24, 2009 1 message not in the archive

Share & tools

Warren Togami

author

2009-06-23 17:23 UTC #0 lore raw

Quoted 10 lines

# This script is sourced, so root should be set. But let's be paranoid [ -z "$root" ] && root=$(getarg root=)
[ -z "$netroot" ] && netroot=$(getarg netroot=)
[ -z "$nfsroot" ] && nfsroot=$(getarg nfsroot=)
# Handle old style <server-ip>:/<path
case "$netroot" in
    [0-9]*:/*|[0-9]*\.[0-9]*\.[0-9]*[!:]|/*)
       netroot=nfs:$netroot;;
esac

By the current code it seems the old style root=<server-ip>:/<path> is not actually handled.

I'm soon pushing a patch that restricts NFS to only root= which should fix this and eliminate the redundant root= and netroot= test cases.

Warren Togami
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Seewer Philippe

2009-06-24 06:51 UTC #2 lore raw

In reply to a message not in the archive

Quoted 5 lines · Warren Togami

Quoted 5 lines
# This script is sourced, so root should be set. But let's be paranoid [ -z "$root" ] && root=$(getarg root=)
[ -z "$netroot" ] && netroot=$(getarg netroot=)
[ -z "$nfsroot" ] && nfsroot=$(getarg nfsroot=)

Quoted 7 lines

Quoted 5 lines
# Handle old style <server-ip>:/<path
case "$netroot" in
    [0-9]*:/*|[0-9]*\.[0-9]*\.[0-9]*[!:]|/*)
       netroot=nfs:$netroot;;
esac
By the current code it seems the old style root=<server-ip>:/<path> is not actually handled.

The current code only handles netroot=<oldstyle>. This works for cmdline or if <oldstyle> is delivered by dhcp root-path. I think that was haralds intention anyway.

Quoted 8 lines

I'm soon pushing a patch that restricts NFS to only root= which should fix this and eliminate the redundant root= and netroot= test cases.
Warren Togami
[email protected]
Signature · 3 lines
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html